-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ProcessingResponse #10196
Introduce ProcessingResponse #10196
Conversation
ProcessingResponse contains the value which should be send as answer to an user command, and request and streamId which identifies the related request. The response will be created in the ProcessingResultBuilder and return as ProcessResult
Use the ProcessingResponse in the ProcessingResult and use it in the ProcessingStateMachine
137faf2
to
b1fcff9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. But I think you should also add a test using the new StreamingPlatformExtension to test that after processing response is sent.
* Do not require certain method order * adjust assertions to match rejection
Thanks @deepthidevaki for your review 🙇 Actually we have already some see here https://github.com/camunda/zeebe/blob/main/engine/src/test/java/io/camunda/zeebe/engine/processing/streamprocessor/StreamProcessorTest.java#L454 I had to fix them in this PR, since they made some order assumptions. I will migrate them soon to the extension, which is why I didn't wrote a new one right now. Hope that is fine for you. |
bors r+ |
Build succeeded: |
Description
blocked by #10191 ✅
blocked by #10188 ✅
Introduce the ProcessingResponse, which encapsulates the information of the Record which should be send as response on a user command and the request- and streamId which identifies the request.
The ProcessingResponse usage replaces the usage of the CommandResponseWriter, and deletes several now unused code.
Related issues
closes #10001
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.