-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport stable/1.3] fix(raft): follower resets pending snapshot after rejecting install request #10211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When comparing compacted logs, not all entries exist in all logs. So compare only the entries that exist. (cherry picked from commit 773dfa2)
(cherry picked from commit 5db2932)
When follower responds with any error, leader restarts send the snapshot from the initial chunk. When the follower has not resets its state, then the follower is not expecting the initial chunk. As a result, the follower reject the requests and this will continue endlessly. (cherry picked from commit 9aba732)
…iability (cherry picked from commit fe11e34)
(cherry picked from commit 6a39814)
There were some cases where the log is not reset and leads to scenarios where a follower is not able to replicate new events. This case is explained in #10183 (comment) (cherry picked from commit 4c82bd9)
(cherry picked from commit 43c96cd)
(cherry picked from commit d79b730)
(cherry picked from commit 1362765)
(cherry picked from commit 455a09c)
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com> (cherry picked from commit 69df0fa)
deepthidevaki
changed the title
[Backport stable/8.0] fix(raft): follower resets pending snapshot after rejecting install request
[Backport stable/1.3] fix(raft): follower resets pending snapshot after rejecting install request
Aug 29, 2022
@oleschoenburg Nothing to look for, there was a minor merge conflict which failed auto backport. |
lenaschoenburg
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 29, 2022
10211: [Backport stable/1.3] fix(raft): follower resets pending snapshot after rejecting install request r=oleschoenburg a=deepthidevaki ## Description Backport #10183 closes #10180 #10202 Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com> Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@users.noreply.github.com>
Build failed: |
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 29, 2022
10211: [Backport stable/1.3] fix(raft): follower resets pending snapshot after rejecting install request r=deepthidevaki a=deepthidevaki ## Description Backport #10183 closes #10180 #10202 Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com> Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@users.noreply.github.com>
Build failed: |
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 30, 2022
10211: [Backport stable/1.3] fix(raft): follower resets pending snapshot after rejecting install request r=deepthidevaki a=deepthidevaki ## Description Backport #10183 closes #10180 #10202 Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com> Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@users.noreply.github.com>
Build failed: |
bors retry |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 30, 2022
10211: [Backport stable/1.3] fix(raft): follower resets pending snapshot after rejecting install request r=deepthidevaki a=deepthidevaki ## Description Backport #10183 closes #10180 #10202 Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com> Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@users.noreply.github.com>
Build failed: |
😭 bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 30, 2022
10211: [Backport stable/1.3] fix(raft): follower resets pending snapshot after rejecting install request r=deepthidevaki a=deepthidevaki ## Description Backport #10183 closes #10180 #10202 Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com> Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@users.noreply.github.com>
Build failed: |
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #10183
closes #10180 #10202