Fix release script #10279
Fix release script #10279
Conversation
.ci/scripts/release/prepare.sh
Outdated
| curl -L https://github.com/cli/cli/releases/download/v2.14.7/gh_2.14.7_linux_amd64.deb --output /tmp/gh.deb | ||
| dpkg -i /tmp/gh.deb | ||
|
|
||
| # Have to set the safe directory otherwise git commands fails with fatal: detected dubious ownership in repository at '/home/jenkins/agent/workspace/zeebe-release' |
There was a problem hiding this comment.
I'm not sure where this is necessary, or when did this break 🤔 We've been using git for a while. Anyway 👍
There was a problem hiding this comment.
Script fails without this. Now sure why it fails now, and was working before.
.ci/scripts/release/prepare.sh
Outdated
| apt update | ||
| apt install -y gpg gh | ||
| apt install -y gpg git |
There was a problem hiding this comment.
❌ It's not required to install git, we were previously only installing gpg. I expect the addition of setting the safe directory is only required because we're overwriting the existing git install with this command.
There was a problem hiding this comment.
Where is the existing git coming from? I added it because gh has a dependency to git and assumed previously it was installed automatically by apt when installing gh.
There was a problem hiding this comment.
I would assume it's already in the image? You can look at the revision before we added gh, and we were only installing gpg (but using git already)
There was a problem hiding this comment.
You are right. The base image is maven:3.8.4-eclipse-temurin-17 and it already contains git. So I will remove installing git and the setting of safe directory. Hope this will work next time :)
git already exists in the base image
.ci/scripts/release/prepare.sh
Outdated
| @@ -2,11 +2,13 @@ | |||
|
|
|||
| # update apt repositories and install missing utilities | |||
| # add GitHub packages Debian repository for gh | |||
There was a problem hiding this comment.
🔧 this comment is out dated now
| # add GitHub packages Debian repository for gh |
|
bors merge |
|
Build succeeded: |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-10279-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-10279-to-stable/8.0
git checkout -b backport-10279-to-stable/8.0
ancref=$(git merge-base d26dbb66d6e29d3634a998f4def711c1f5043cab 2e0ebca80f7beeefda0fe84b961aa6ccf1fb896a)
git cherry-pick -x $ancref..2e0ebca80f7beeefda0fe84b961aa6ccf1fb896a |
Description
This PR contains fixes for issue found while releasing 8.1.0-alpha5.