Auto merge patch dependency updates #10333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npepinpe
force-pushed
the
10295-auto-merge
branch
3 times, most recently
from
3170c75
to
429a22a
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
🔒 Permission denied Existing reviewers: click here to make github-actions[bot] a reviewer |
|
So all good, but it seems the GitHub bot is not an approved review ;) |
|
For testing, see this run: https://github.com/camunda/zeebe/actions/runs/3045213733/jobs/4906497130 |
npepinpe
force-pushed
the
10295-auto-merge
branch
from
931150c
to
6d6a652
Compare
|
After merging, we would simply add the GitHub actions bot to the bors reviewers. If that's not desirable, we can use a PAT, but I can't see a reason why it won't be desirable. |
|
One last thing, I wasn't sure how to test the dependabot part without a dependabot PR, so we will find out on the first dependabot PR. |
korthout
approved these changes
Sep 13, 2022
Comment on lines
+10
to
+12
| # Once we're using the merge queue feature, I think we can simplify this workflow a lot by relying | ||
| # on dependabot merging PRs via its commands, as it will always wait for checks to be green before | ||
| # merging. |
| - uses: actions/checkout@v3 | ||
| - id: metadata | ||
| name: Fetch dependency metadata | ||
| if: false |
There was a problem hiding this comment.
❓ if: false, so this step is always skipped? If so, please clean it up.
There was a problem hiding this comment.
No, that's a left over for testing, my bad 🙈
Adds a workflow which runs whenever a PR is opened, reopened, marked as ready for review (so going from draft to ready), and updated (synchronized). The latter is to allow things such as `@dependabot rebase` to trigger this workflow. This workflow runs only if the author of the PR is dependabot, and if the repository is `camunda/zeebe`. It will only merge patch updates for now, but it could be updated to merge any kind of updates.
npepinpe
force-pushed
the
10295-auto-merge
branch
from
6d6a652
to
3c81194
Compare
|
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Sep 14, 2022
10333: Auto merge patch dependency updates r=npepinpe a=npepinpe ## Description This PR adds a workflow which runs on every dependabot PRs, and will automatically merge the PR iff the checks pass, and it is a patch version (according to dependabot). Merging is still done via bors. The workflow is made of three steps: checking the dependabot metadata (used to determine the type of updates, e.g. patch, minor, etc.), waiting for specific checks to pass, then approving the PR with a `bors merge` comment (triggering the merge). If bors fails to merge, or checks fail, then manual action is still required. ## Related issues closes #10295 Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
|
Timed out. |
|
Nice to see it in action @npepinpe 🚀 |
Zelldon
added
the
version:8.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a workflow which runs on every dependabot PRs, and will automatically merge the PR iff the checks pass, and it is a patch version (according to dependabot). Merging is still done via bors.
The workflow is made of three steps: checking the dependabot metadata (used to determine the type of updates, e.g. patch, minor, etc.), waiting for specific checks to pass, then approving the PR with a
bors mergecomment (triggering the merge).If bors fails to merge, or checks fail, then manual action is still required.
Related issues
closes #10295
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.