Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reuse of shared actuators depending on BrokerClient #10357

Merged
merged 5 commits into from
Sep 15, 2022

Conversation

npepinpe
Copy link
Member

Description

This PR provides the last remaining bit to #9996 by having each application provide a BrokerClient bean, allowing us to create shared actuators which do not need any bridge. To showcase, the RebalancingService was collapsed into a single class.

Related issues

closes #9996
depends on #10354

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2022

Test Results

   858 files  ±  0     858 suites  ±0   1h 50m 30s ⏱️ + 2m 52s
6 641 tests +41  6 630 ✔️ +41  11 💤 ±0  0 ±0 
6 825 runs  +41  6 814 ✔️ +41  11 💤 ±0  0 ±0 

Results for commit 78a584f. ± Comparison against base commit 870286d.

♻️ This comment has been updated with latest results.

@npepinpe
Copy link
Member Author

Forgot to start the broker client on the actor scheduler is started. This is kind of hacky, as the StandaloneBroker also needs the client to be injected so it can start it after the actor scheduler.

Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Looks great.
Just two minor comments. Please take a look before merging.

@npepinpe
Copy link
Member Author

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 9dbf225 into main Sep 15, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 9996-broker-client branch September 15, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actuators are cumbersome to maintain and extend
2 participants