-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow reuse of shared actuators depending on BrokerClient #10357
Conversation
Forgot to start the broker client on the actor scheduler is started. This is kind of hacky, as the |
b634e35
to
f5c6855
Compare
53469ef
to
41bed32
Compare
e9e8bde
to
b5e5af9
Compare
152b82f
to
870286d
Compare
b5e5af9
to
78a584f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Looks great.
Just two minor comments. Please take a look before merging.
qa/util/src/main/java/io/camunda/zeebe/qa/util/actuator/RebalanceActuator.java
Outdated
Show resolved
Hide resolved
qa/integration-tests/src/test/java/io/camunda/zeebe/it/management/RebalancingEndpointIT.java
Outdated
Show resolved
Hide resolved
Collapses implementation of the `RebalancingService` now that both applications can easily provide a `BrokerClient`
78a584f
to
22ef72c
Compare
bors merge |
Build succeeded: |
Description
This PR provides the last remaining bit to #9996 by having each application provide a
BrokerClient
bean, allowing us to create shared actuators which do not need any bridge. To showcase, theRebalancingService
was collapsed into a single class.Related issues
closes #9996
depends on #10354
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.