Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify the unit of retryBackOff #10448

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Specify the unit of retryBackOff #10448

merged 2 commits into from
Sep 23, 2022

Conversation

remcowesterhoud
Copy link
Contributor

Description

Specify that the job retryBackOff should be in milliseconds.

Related issues

N/A

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2022 •
edited

Test Results

   867 files  ±    0     867 suites  ±0   1h 48m 12s ⏱️ + 5m 8s
6 786 tests +186  6 776 ✔️ +186  10 💤 ±0  0 ❌ ±0 
6 970 runs  +186  6 960 ✔️ +186  10 💤 ±0  0 ❌ ±0 

Results for commit c531ebd. ± Comparison against base commit ea68555.

♻️ This comment has been updated with latest results.

saig0
saig0 approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remcowesterhoud thank you. 👍

gateway-protocol/src/main/proto/gateway.proto Outdated Show resolved Hide resolved
@saig0
Copy link
Member

saig0 commented Sep 23, 2022

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Sep 23, 2022
@zeebe-bors-camunda @remcowesterhoud @saig0
merge: #10448
310459b 
10448: Specify the unit of retryBackOff r=saig0 a=remcowesterhoud

## Description

<!-- Please explain the changes you made here. -->
Specify that the job `retryBackOff` should be in milliseconds.

## Related issues

<!-- Which issues are closed by this PR or are related -->

N/A



Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
@zeebe-bors-camunda
Copy link
Contributor

Timed out.

@saig0
Copy link
Member

saig0 commented Sep 23, 2022

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Sep 23, 2022
@zeebe-bors-camunda @remcowesterhoud
@saig0 @dependabot
merge: #10448 #10461 #10462
1b5ac13 
10448: Specify the unit of retryBackOff r=saig0 a=remcowesterhoud

## Description

<!-- Please explain the changes you made here. -->
Specify that the job `retryBackOff` should be in milliseconds.

## Related issues

<!-- Which issues are closed by this PR or are related -->

N/A



10461: deps(maven): bump aws-java-sdk-core from 1.12.308 to 1.12.309 r=github-actions[bot] a=dependabot[bot]

Bumps [aws-java-sdk-core](https://github.com/aws/aws-sdk-java) from 1.12.308 to 1.12.309.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md">aws-java-sdk-core's changelog</a>.</em></p>
<blockquote>
<h1><strong>1.12.309</strong> <strong>2022-09-22</strong></h1>
<h2><strong>AWS Backup Gateway</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Changes include: new GetVirtualMachineApi to fetch a single user's VM, improving ListVirtualMachines to fetch filtered VMs as well as all VMs, and improving GetGatewayApi to now also return the gateway's MaintenanceStartTime.</li>
</ul>
</li>
</ul>
<h2><strong>AWS Device Farm</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>This release adds the support for VPC-ENI based connectivity for private devices on AWS Device Farm.</li>
</ul>
</li>
</ul>
<h2><strong>AWS Glue</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Added support for S3 Event Notifications for Catalog Target Crawlers.</li>
</ul>
</li>
</ul>
<h2><strong>AWS SSO Identity Store</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Documentation updates for the Identity Store CLI Reference.</li>
</ul>
</li>
</ul>
<h2><strong>Amazon Elastic Compute Cloud</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Documentation updates for Amazon EC2.</li>
</ul>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/aws/aws-sdk-java/commit/dab3ce334bba719453a4587cea633a6462c4121f"><code>dab3ce3</code></a> AWS SDK for Java 1.12.309</li>
<li><a href="https://github.com/aws/aws-sdk-java/commit/765446355993783014b67b1d1f4456ec6c4f5215"><code>7654463</code></a> Update GitHub version number to 1.12.309-SNAPSHOT</li>
<li>See full diff in <a href="https://github.com/aws/aws-sdk-java/compare/1.12.308...1.12.309">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.amazonaws:aws-java-sdk-core&package-manager=maven&previous-version=1.12.308&new-version=1.12.309)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

10462: deps(maven): bump software.amazon.awssdk:bom from 2.17.278 to 2.17.280 r=github-actions[bot] a=dependabot[bot]

Bumps [software.amazon.awssdk:bom](https://github.com/aws/aws-sdk-java-v2) from 2.17.278 to 2.17.280.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/aws/aws-sdk-java-v2/blob/master/CHANGELOG.md">software.amazon.awssdk:bom's changelog</a>.</em></p>
<blockquote>
<h1><strong>2.17.280</strong> <strong>2022-09-22</strong></h1>
<h2><strong>AWS Backup Gateway</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Changes include: new GetVirtualMachineApi to fetch a single user's VM, improving ListVirtualMachines to fetch filtered VMs as well as all VMs, and improving GetGatewayApi to now also return the gateway's MaintenanceStartTime.</li>
</ul>
</li>
</ul>
<h2><strong>AWS Device Farm</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>This release adds the support for VPC-ENI based connectivity for private devices on AWS Device Farm.</li>
</ul>
</li>
</ul>
<h2><strong>AWS Glue</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Added support for S3 Event Notifications for Catalog Target Crawlers.</li>
</ul>
</li>
</ul>
<h2><strong>AWS SDK for Java v2</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Updated service endpoint metadata.</li>
</ul>
</li>
</ul>
<h2><strong>AWS SSO Identity Store</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Documentation updates for the Identity Store CLI Reference.</li>
</ul>
</li>
</ul>
<h2><strong>Amazon Elastic Compute Cloud</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Documentation updates for Amazon EC2.</li>
</ul>
</li>
</ul>
<h1><strong>2.17.279</strong> <strong>2022-09-21</strong></h1>
<h2><strong>AWS S3 Control</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>S3 on Outposts launches support for object versioning for Outposts buckets. With S3 Versioning, you can preserve, retrieve, and restore every version of every object stored in your buckets. You can recover from both unintended user actions and application failures.</li>
</ul>
</li>
</ul>
<h2><strong>AWS SDK for Java v2</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Updated service endpoint metadata.</li>
</ul>
</li>
<li>
<h3>Bugfixes</h3>
<ul>
<li>Fixed issue where errors were being wrapped by SdkClientException</li>
</ul>
</li>
</ul>
<h2><strong>Amazon Comprehend</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>Amazon Comprehend now supports synchronous mode for targeted sentiment API operations.</li>
</ul>
</li>
</ul>
<h2><strong>Amazon SageMaker Service</strong></h2>
<ul>
<li>
<h3>Features</h3>
<ul>
<li>SageMaker now allows customization on Canvas Application settings, including enabling/disabling time-series forecasting and specifying an Amazon Forecast execution role at both the Domain and UserProfile levels.</li>
</ul>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/aws/aws-sdk-java-v2/commit/ea3d8838bd54c96b559f25c4d3238b63dfd92c84"><code>ea3d883</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/aws/aws-sdk-java-v2/issues/2151">#2151</a> from aws/staging/40fbf60b-c3e9-458a-b106-4c80e497adf1</li>
<li><a href="https://github.com/aws/aws-sdk-java-v2/commit/697221433153dbf228deeed020e2ecf0fbc3163a"><code>6972214</code></a> Release 2.17.280. Updated CHANGELOG.md, README.md and all pom.xml.</li>
<li><a href="https://github.com/aws/aws-sdk-java-v2/commit/503ce29845146fbe71254fc273d22f8d1149a30c"><code>503ce29</code></a> Updated endpoints.json.</li>
<li><a href="https://github.com/aws/aws-sdk-java-v2/commit/e1850bb772b5109fb188f97815fc34b7c2badf84"><code>e1850bb</code></a> AWS Device Farm Update: This release adds the support for VPC-ENI based conne...</li>
<li><a href="https://github.com/aws/aws-sdk-java-v2/commit/e6b79ce62d7ba9ada2f29c0d85de7a587d4c1e67"><code>e6b79ce</code></a> AWS Backup Gateway Update: Changes include: new GetVirtualMachineApi to fetch...</li>
<li><a href="https://github.com/aws/aws-sdk-java-v2/commit/da00d51297e437aa509b7d3a73b74e4e0f5c1f81"><code>da00d51</code></a> AWS SSO Identity Store Update: Documentation updates for the Identity Store C...</li>
<li><a href="https://github.com/aws/aws-sdk-java-v2/commit/fe6efc050628fe91e0ec7a2bfcc34fb206fa714d"><code>fe6efc0</code></a> AWS Glue Update: Added support for S3 Event Notifications for Catalog Target ...</li>
<li><a href="https://github.com/aws/aws-sdk-java-v2/commit/c8dfc89b8bb345bfa513834b182fb55659a37da3"><code>c8dfc89</code></a> Amazon Elastic Compute Cloud Update: Documentation updates for Amazon EC2.</li>
<li><a href="https://github.com/aws/aws-sdk-java-v2/commit/98e21b1d8a8a6cde598c8202979b3ba6c08775d1"><code>98e21b1</code></a> Update to next snapshot version: 2.17.280-SNAPSHOT</li>
<li><a href="https://github.com/aws/aws-sdk-java-v2/commit/f3e99c64eb01477737b9b6b470ed2f1cd52e0b85"><code>f3e99c6</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/aws/aws-sdk-java-v2/issues/2035">#2035</a> from aws/salande/object-versioning</li>
<li>Additional commits viewable in <a href="https://github.com/aws/aws-sdk-java-v2/compare/2.17.278...2.17.280">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=software.amazon.awssdk:bom&package-manager=maven&previous-version=2.17.278&new-version=2.17.280)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed (retrying...):

@saig0 saig0 merged commit 241ec37 into main Sep 23, 2022
@saig0 saig0 deleted the job_retry_backoff branch September 23, 2022 12:09
@backport-action backport-action mentioned this pull request Sep 23, 2022
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR #10466 for stable/8.0.

zeebe-bors-camunda bot added a commit that referenced this pull request Sep 23, 2022
@zeebe-bors-camunda @saig0 @remcowesterhoud
merge: #10465 #10466
ea0c80b 
10465: deps(maven): bump feel-engine from 1.14.2 to 1.14.3 r=remcowesterhoud a=saig0

## Description

Bumps [feel-engine](https://github.com/camunda/feel-scala) from `1.14.2` to `1.14.3`.

## Related issues



10466: [Backport stable/8.0] Specify the unit of retryBackOff r=remcowesterhoud a=backport-action

# Description
Backport of #10448 to `stable/8.0`.

relates to 

Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
zeebe-bors-camunda bot added a commit that referenced this pull request Sep 23, 2022
@zeebe-bors-camunda @saig0 @remcowesterhoud
merge: #10465 #10466
c0eaa59 
10465: deps(maven): bump feel-engine from 1.14.2 to 1.14.3 r=remcowesterhoud a=saig0

## Description

Bumps [feel-engine](https://github.com/camunda/feel-scala) from `1.14.2` to `1.14.3`.

## Related issues



10466: [Backport stable/8.0] Specify the unit of retryBackOff r=oleschoenburg a=backport-action

# Description
Backport of #10448 to `stable/8.0`.

relates to 

Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
@deepthidevaki
Copy link
Contributor

bors r-

already merged

@zeebe-bors-camunda
Copy link
Contributor

Canceled.

@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saig0 saig0 saig0 approved these changes

Assignees
No one assigned
Labels
version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@remcowesterhoud @saig0 @backport-action @deepthidevaki @megglos @Zelldon