Diverge stream processor packages from engine #10454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create the key generator in the StreamProcessor, since the key is part of the Record metadata, which is know by the StreamProcessor and needs to be reset during replay. The keygenerator is part of the RecordProcessorContext and corresponding API.
The keygenerator is no longer created inside the ZeebeState, it is passed into the CTOR from outside. Coming from the RecordProcessorContext, created by the streamprocessor.
10 tasks
|
I will keep the branch, but close the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Iterate over the engine and stream processor packages, renamed and reorganized them. This should make it easier to make a split soon. I realized during doing this some smaller blockers which we need to tackler before completely separating the modules.
See #10130
Blocked by #10440
Related issues
See #10130
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.