Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(engine): speed up the inclusive gateway test #10479

Merged
merged 1 commit into from
Sep 27, 2022
Merged

test(engine): speed up the inclusive gateway test #10479

merged 1 commit into from
Sep 27, 2022

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Sep 26, 2022

Description

The test case to verify activated tasks took 15 seconds to complete. In the test, we limited the record stream by the completion of the process instance. Since the process instance was not completed, the test waited 5 seconds until reaching the timeout. This was done 3 times.

Changing the service tasks in the process to manual tasks. Manual tasks have a pass-through and are immediately completed. As a result, we can limit the record stream because the process instance is immediately completed. The service tasks were not semantical important for the test case.

Related issues

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@saig0
test(engine): speed up the inclusive gateway test
cec2768 
The test case to verify activated tasks took 15 seconds to complete. In the test, we limited the record stream by the completion of the process instance. Since the process instance were not completed, the test waited 5 seconds until reaching the timeout. This was done 3 times.

Changing the service tasks in the process to manual tasks. Manual tasks has a pass-through and are immediately completed. As a result, we can limit the record stream because the process instance is immediately completed. The service tasks were not semantical important for the test case.
@github-actions
Copy link
Contributor

Test Results

   930 files     930 suites   2h 32m 12s ⏱️
7 576 tests 7 560 ✔️ 10 💤 6 ❌
7 712 runs  7 696 ✔️ 10 💤 6 ❌

For more details on these failures, see this check.

Results for commit cec2768.

@saig0 saig0 marked this pull request as ready for review September 26, 2022 08:04
remcowesterhoud
remcowesterhoud approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @saig0 🚀

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 01f5df2 into main Sep 27, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the speed-up-inclusive-gateway-test branch September 27, 2022 07:52
@saig0
Copy link
Member Author

saig0 commented Sep 27, 2022

/backport

@backport-action backport-action mentioned this pull request Sep 27, 2022
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR #10512 for release-8.1.0.

zeebe-bors-camunda bot added a commit that referenced this pull request Sep 27, 2022
@zeebe-bors-camunda @saig0
merge: #10512
29a1a43 
10512: [Backport release-8.1.0] test(engine): speed up the inclusive gateway test r=saig0 a=backport-action

# Description
Backport of #10479 to `release-8.1.0`.

relates to 

Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcowesterhoud remcowesterhoud remcowesterhoud approved these changes

Assignees
No one assigned
Labels
version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saig0 @backport-action @remcowesterhoud @Zelldon