Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dispatcher): fix potential sigsev in tests #10538

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

npepinpe
Copy link
Member

Description

Ensure all actors which access the dispatcher (and cache parts of the direct buffer) are closed before the dispatcher is closed itself.

Related issues

closes #10407

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

Ensure all actors which access the dispatcher (and cache parts of the
direct buffer) are closed before the dispatcher is closed itself.
Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

Test Results

   933 files  ±  0     933 suites  ±0   2h 3m 46s ⏱️ - 1m 26s
7 367 tests  - 10  7 357 ✔️  - 10  10 💤 ±0  0 ±0 
7 555 runs   - 10  7 545 ✔️  - 10  10 💤 ±0  0 ±0 

Results for commit 507e45a. ± Comparison against base commit c0b3ffc.

@deepthidevaki
Copy link
Contributor

bors r+

zeebe-bors-camunda bot added a commit that referenced this pull request Sep 28, 2022
10538: test(dispatcher): fix potential sigsev in tests r=deepthidevaki a=npepinpe

## Description

Ensure all actors which access the dispatcher (and cache parts of the direct buffer) are closed before the dispatcher is closed itself.

## Related issues

closes #10407 



Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@npepinpe
Copy link
Member Author

bors r+

Some flaky integration tests, but nothing related to these changes

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@backport-action
Copy link
Collaborator

Successfully created backport PR #10546 for stable/8.0.

zeebe-bors-camunda bot added a commit that referenced this pull request Sep 28, 2022
10546: [Backport stable/8.0] test(dispatcher): fix potential sigsev in tests r=npepinpe a=backport-action

# Description
Backport of #10538 to `stable/8.0`.

relates to #10407

Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActorFrameworkIntegrationTest causes SIGSEG
4 participants