Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not copy ResultBatch everytime #10557

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Do not copy ResultBatch everytime #10557

merged 2 commits into from
Sep 29, 2022

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Sep 29, 2022

Description

I have seen when running shouldPreserveOrderingOfWritesEvenWithRetries that it sometimes can happen that the writing (retry loop) can take up to 3 seconds, where the timeout is 2 seconds. I think this is related to the that we always copy again in the loop (which is not necessary).

I also have observed in #10526 (comment)

Related to #10458

Related issues

related to #10458
related to #10526

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a nice improvement 🚀

@Zelldon
Copy link
Member Author

Zelldon commented Sep 29, 2022

bors r+

@github-actions
Copy link
Contributor

Test Results

   760 files   -    173     760 suites   - 173   1h 38m 9s ⏱️ - 29m 5s
6 061 tests  - 1 362  6 050 ✔️  - 1 363  10 💤 ±0  1 +1 
6 239 runs   - 1 372  6 228 ✔️  - 1 373  10 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit 10d1c2b. ± Comparison against base commit 2c5a067.

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@backport-action
Copy link
Collaborator

Successfully created backport PR #10558 for release-8.1.0.

zeebe-bors-camunda bot added a commit that referenced this pull request Sep 29, 2022
10558: [Backport release-8.1.0] Do not copy ResultBatch everytime r=Zelldon a=backport-action

# Description
Backport of #10557 to `release-8.1.0`.

relates to #10526

Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants