Add verification timeout to SuccessfulDeploymentTest.shouldSendResponse #10573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Zelldon
requested review from
saig0 and
a team
and removed request for
megglos,
lenaschoenburg and
saig0
The test was not reliable since the ordering of the command response writer wock was not the same as in the code, this means it could happen that the writer was not yet called on all methods. It was easier to reproduce and also to fix.
Zelldon
force-pushed
the
zell-fix-successful-deployment
branch
from
38a2350
to
20fa4cb
Compare
saig0
approved these changes
Sep 30, 2022
|
Bors r+ |
|
Build succeeded: |
|
Successfully created backport PR #10576 for |
|
Successfully created backport PR #10577 for |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Sep 30, 2022
10494: [Backport stable/8.0] Do not fail consistency check if log is empty r=deepthidevaki a=backport-action # Description Backport of #10463 to `stable/8.0`. relates to #10451 10576: [Backport stable/8.0] Add verification timeout to SuccessfulDeploymentTest.shouldSendResponse r=saig0 a=backport-action # Description Backport of #10573 to `stable/8.0`. relates to #10492 Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com> Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
Zelldon
added
the
version:8.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test was not reliable since the ordering of the command response writer mock was not the same as in the code, this means it could happen that the writer was not yet called on all methods. It was easy to reproduce and also to fix. I rerun the test after the fix 1000+ times.
Related issues
closes #10492
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.