Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport stable/8.1] Fix NPE during PI modification #10608

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

backport-action
Copy link
Collaborator

Description

Backport of #10601 to stable/8.1.

relates to #10537

Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Oct 5, 2022
10608: [Backport stable/8.1] Fix NPE during PI modification r=remcowesterhoud a=backport-action

# Description
Backport of #10601 to `stable/8.1`.

relates to #10537

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Test Results

   934 files  ±  0     934 suites  ±0   2h 4m 2s ⏱️ - 2m 8s
7 377 tests +70  7 369 ✔️ +70  8 💤 ±0  0 ±0 
7 565 runs  +70  7 557 ✔️ +70  8 💤 ±0  0 ±0 

Results for commit 5289b6e. ± Comparison against base commit 8b7ebd8.

…ement

If a command is received in which both the multi instance body, as well as the nested element gets terminated we should be able to handle this without exceptions.

(cherry picked from commit 5df6a7d)
A command could contain multiple terminate instruction that result in the termination of the same element instance. For example, when we have a sub process and a nested element. If both this sub process and the nested element are part of the terminate instructions, the nested element will be terminated twice.

When we receive the command we verify that all instances exist. However, once the first terminate instruction terminates the element, the instance no longer exist for the second terminate instruction. When this occurs we should ignore the terminate instruction.

(cherry picked from commit 43b0a1d)
@remcowesterhoud
Copy link
Contributor

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 9fa438c into stable/8.1 Oct 7, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the backport-10601-to-stable/8.1 branch October 7, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants