-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate StreamProcessorInconsistentPositionTest #10636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the test and extension classes to right package
In the stream platform tests we need to sometimes to inject different list storages etc. for that we make the log storage in the extension more configurable
Migrate StreamProcessorInconsistentPositionTest to new StreamPlatformExtension
lenaschoenburg
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀
I have one question/suggestion that you should look at before merging.
.../src/test/java/io/camunda/zeebe/streamprocessor/StreamProcessorInconsistentPositionTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/io/camunda/zeebe/streamprocessor/StreamProcessorInconsistentPositionTest.java
Outdated
Show resolved
Hide resolved
engine/src/test/java/io/camunda/zeebe/streamprocessor/StreamPlatform.java
Outdated
Show resolved
Hide resolved
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
related to #10455
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.