Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate StreamProcessorInconsistentPositionTest #10636

Merged
merged 6 commits into from
Oct 7, 2022

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Oct 7, 2022

Description

  • Move some classes to right packages
  • Make the log storage better accessible and configruable in StreamPlatform
  • Migrate StreamProcessorInconsistentPositionTest

Related issues

related to #10455

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

Move the test and extension classes to right package
In the stream platform tests we need to sometimes to inject different list storages etc. for that we make the log storage in the extension more configurable
Migrate StreamProcessorInconsistentPositionTest to new StreamPlatformExtension
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Test Results

   936 files  ±    0     936 suites  ±0   1h 45m 51s ⏱️ - 6m 10s
7 414 tests  - 291  7 408 ✔️  - 291  6 💤 ±0  0 ±0 
7 604 runs   - 291  7 596 ✔️  - 291  8 💤 ±0  0 ±0 

Results for commit 17065bc. ± Comparison against base commit 70c0fd2.

♻️ This comment has been updated with latest results.

Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

I have one question/suggestion that you should look at before merging.

@Zelldon
Copy link
Member Author

Zelldon commented Oct 7, 2022

bors r+

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 6353407 into main Oct 7, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the zell-migrate-test branch October 7, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants