Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add record and intent for escalation #10780

Merged
merged 3 commits into from
Oct 25, 2022

Conversation

lzgabel
Copy link
Contributor

@lzgabel lzgabel commented Oct 20, 2022

Description

Add record and intent for escalation and export escalation record to ES.

Related issues

closes #10762
closes #10767

Definition of Done

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@lzgabel
Copy link
Contributor Author

lzgabel commented Oct 20, 2022

Hi @remcowesterhoud. Please take a moment to check this out. 🙇

@remcowesterhoud remcowesterhoud self-assigned this Oct 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

Test Results

   947 files  ±    0     947 suites  ±0   1h 41m 20s ⏱️ - 1m 9s
7 687 tests +156  7 680 ✔️ +156  7 💤 ±0  0 ±0 
7 879 runs  +156  7 870 ✔️ +156  9 💤 ±0  0 ±0 

Results for commit 823c622. ± Comparison against base commit 83cce27.

♻️ This comment has been updated with latest results.

@lzgabel
Copy link
Contributor Author

lzgabel commented Oct 24, 2022

Hi @remcowesterhoud. This PR is ready for review, please take a moment to check it out. 🙇

Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @lzgabel! I have nothing to say about 👍

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 23c6bc5 into camunda:main Oct 25, 2022
@lzgabel lzgabel deleted the 10762-lz-escalation-record branch October 25, 2022 08:24
@saig0 saig0 added the hacktoberfest-accepted Marks an issue as having been accepted as a Hacktoberfest contribution label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Marks an issue as having been accepted as a Hacktoberfest contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export escalation records to ElasticSearch Create EscalationRecord and EscalationIntent
3 participants