Migrate the replay mode test #10879
Merged
Migrate the replay mode test #10879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
Rename NewStreamProcessorReplayModeTest to StreamProcessorContinouslyReplayModeTest to make more clear what the test contains and does.
Allow to reset the log context, useful for restart/restore tests. Allow to set the processing mode.
Migrate new tests: * shouldReplayContinuously * shouldReplayIfNoEventsAfterSnapshot (mark as regression test)
This test is already part of StreamProcessorReplayTest
Migrates the StreamProcessorReplayModeTest to JUNIT 5 and the StreamPlatform extension. New test is called StreamProcessorContinouslyReplayModeTest.java . The test execution is reduced and the tests have been rewriten and improved
Zelldon
force-pushed
the
zell-replay-mode-test
branch
from
de8063c
to
555f2b2
Compare
Add a new start method, instead of setting the process mode separately before starting the processor
9 tasks
|
@npepinpe I have rebased this PR please have a look. |
npepinpe
approved these changes
Nov 3, 2022
Comment on lines
+42
to
+43
| @SuppressWarnings("unused") // injected by the extension | ||
| private StreamPlatform streamPlatform; |
There was a problem hiding this comment.
💭 If we ever wanted to get rid of this warning, there is another way of injecting fields which is using a constructor parameter resolver. It's a more flexible way (if more verbose) to inject stuff, since you can either scope it to the instance lifecycle (via constructors) or to single tests. Just a thought 🤷 This is what I usually favor, but I wouldn't say there's very strong arguments for it.
There was a problem hiding this comment.
Yeah lets leave it for now like this. If we have a strong opinion for one or the other then lets change it everywhere so it is consistent.
|
bors r+ |
|
Build succeeded: |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Nov 4, 2022
10894: Remove StreamProcessorReprocessingTest r=Zelldon a=Zelldon ## Description :x: blocked by #10879 <!-- Please explain the changes you made here. --> Deletes test and verifies for each test method, whether we already have an replacement. ## Related issues <!-- Which issues are closed by this PR or are related --> related to #10455 Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
❌ blocked by #10876Migrates the
StreamProcessorReplayModeTestto JUNIT 5 and uses StreamPlatform extension. The new test is calledStreamProcessorContinouslyReplayModeTest.javaSimilar to #10876 the test execution has been improved. Some additional improvements have been made to verify whether the state is restored and contains the last processed position etc.
One test has been removed since it is already tested in another class and one has been removed since the test doesn't make sense like that.
Related issues
related #10455
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.