fix(benchmark): publish messages with no TTL #10935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the benchmark published messages with a default TTL of one hour. The TTL can cause additional load on the broker. If the benchmark publishes a high rate of message with TTL then it could overload the broker. See #10643. Set the TTL to ZERO and disable the buffering of messages.
9 tasks
npepinpe
approved these changes
Nov 8, 2022
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Nov 8, 2022
10935: fix(benchmark): publish messages with no TTL r=npepinpe a=saig0 ## Description Currently, the benchmark publishes messages with a [default TTL](https://github.com/camunda/zeebe/blob/main/clients/java/src/main/java/io/camunda/zeebe/client/impl/ZeebeClientBuilderImpl.java#L57) of one hour. The TTL can cause additional load on the broker. If the benchmark publishes a high rate of messages with TTL then it could overload the broker. See #10643. Set the TTL to ZERO and disable the buffering of messages. ## Related issues closes #10552 Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
|
Build failed: |
|
bors r+ Known flaky test |
|
Build succeeded: |
|
Successfully created backport PR #10939 for |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Nov 11, 2022
10936: fix(benchmark): enable the message publisher again r=npepinpe a=saig0 ## Description Previously, the message process was disabled because it led to big message states (#10643). This issue was fixed by setting the message TTL to ZERO (#10935). So, we can enable the message process again. ## Related issues Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Nov 11, 2022
10936: fix(benchmark): enable the message publisher again r=npepinpe a=saig0 ## Description Previously, the message process was disabled because it led to big message states (#10643). This issue was fixed by setting the message TTL to ZERO (#10935). So, we can enable the message process again. ## Related issues Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
remcowesterhoud
added
the
version:8.1.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the benchmark publishes messages with a default TTL of one hour. The TTL can cause additional load on the broker. If the benchmark publishes a high rate of messages with TTL then it could overload the broker. See #10643.
Set the TTL to ZERO and disable the buffering of messages.
Related issues
closes #10552
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.