Remove dead code #10977
Merged
Remove dead code #10977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all unused/dead code after migrating tests to the StreamPlatformExtension
|
Flaky test #10978 |
9 tasks
lenaschoenburg
approved these changes
Nov 11, 2022
|
bors r+ |
|
Build succeeded: |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Nov 14, 2022
10979: Extract Streamprocessor from engine module r=Zelldon a=Zelldon ## Description Split the engine module into two separate modules. One called stream-platform (zeebe-stream-platform), the name is of course discussable, which contains everything related to stream processing. This module contains right now the API and implementation. It can and will be split further in the future. There is a new package names `io.camunda.stream.api/impl` etc. Here we can also agree on a different name of course. The other remaining module is still called engine, which contains the record processor implementation. It is the core or business logic of zeebe (the process engine). Right now it still depends on some impl classes like CopiedRecords, RecordValues mostly related to tests. This can hopefully be resolved in the future via iteration over the engine tests. #10004 I prepared some structure in the API and impl, but can also be discussed. There are several classes which have been moved, which we might want to move to a different place later. For example: * ZbColumnFamily * CopiedRecords * RecordValues * etc. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> closes #10977 closes #10130 closes #9727 closes #9600 Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove all unused/dead code from the old StreamProcessorRules, after migrating tests to the StreamPlatformExtension.
Be aware the rules are still necessary since they are used by the EngineRule and tests.
Related issues
closes #10455
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.