Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve flaky timer test #11033

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Resolve flaky timer test #11033

merged 1 commit into from
Nov 18, 2022

Conversation

remcowesterhoud
Copy link
Contributor

Description

We are not entirely sure what the cause of the flakyness is, however by improving the assertions to be more specific to what this test is supposed to fix we expect that the flakyness is resolved.

Related issues

closes #10272

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

We are not entirely sure what the cause of the flakyness is, however by improving the assertions to be more specific to what this test is supposed to fix we expect that the flakyness is resolved.
@github-actions
Copy link
Contributor

Test Results

   957 files  ±  0     957 suites  ±0   1h 41m 26s ⏱️ - 1m 50s
7 636 tests  - 55  7 629 ✔️  - 55  7 💤 ±0  0 ±0 
7 836 runs   - 55  7 827 ✔️  - 55  9 💤 ±0  0 ±0 

Results for commit 3ca46f0. ± Comparison against base commit 929988c.

Copy link
Member

@koevskinikola koevskinikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 6f775d9 into main Nov 18, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 10272_flaky_timer_test branch November 18, 2022 12:58
@backport-action
Copy link
Collaborator

Successfully created backport PR #11051 for stable/8.0.

@backport-action
Copy link
Collaborator

Successfully created backport PR #11052 for stable/8.1.

zeebe-bors-camunda bot added a commit that referenced this pull request Nov 18, 2022
11052: [Backport stable/8.1] Resolve flaky timer test r=remcowesterhoud a=backport-action

# Description
Backport of #11033 to `stable/8.1`.

relates to #10272

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
@remcowesterhoud remcowesterhoud added the version:8.1.4 Marks an issue as being completely or in parts released in 8.1.4 label Nov 22, 2022
zeebe-bors-camunda bot added a commit that referenced this pull request Nov 22, 2022
11051: [Backport stable/8.0] Resolve flaky timer test r=remcowesterhoud a=backport-action

# Description
Backport of #11033 to `stable/8.0`.

relates to #10272

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:8.1.4 Marks an issue as being completely or in parts released in 8.1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky TimerStartEventTest (multiple cases)
3 participants