Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve flaky shouldTriggerTimerTest #11034

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Conversation

remcowesterhoud
Copy link
Contributor

Description

This test was flaky because the margin of the between was too tight. The CI isn't always fast enough to ensure the timer gets triggered between 100-150ms.

Since we don't really like timers of 100ms we changed to a more realistic scenario with a timer of 1 minute. We also increased the margin to have an extra minute to prevent flakyness

Related issues

closes #10978

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

This test was flaky because the margin of the between was too tight. The CI isn't always fast enough to ensure the timer gets triggered between 100-150ms.

Since we don't really like timers of 100ms we changed to a more realistic scenario with a timer of 1 minute. We also increased the margin to have an extra minute to prevent flakyness
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remcowesterhoud 👍

bors merge

@github-actions
Copy link
Contributor

Test Results

   957 files  ±  0     957 suites  ±0   1h 41m 39s ⏱️ - 1m 37s
7 625 tests  - 66  7 618 ✔️  - 66  7 💤 ±0  0 ±0 
7 825 runs   - 66  7 816 ✔️  - 66  9 💤 ±0  0 ±0 

Results for commit 756fd46. ± Comparison against base commit 929988c.

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@backport-action
Copy link
Collaborator

Successfully created backport PR #11035 for stable/8.0.

@backport-action
Copy link
Collaborator

Successfully created backport PR #11036 for stable/8.1.

zeebe-bors-camunda bot added a commit that referenced this pull request Nov 17, 2022
11036: [Backport stable/8.1] Resolve flaky shouldTriggerTimerTest r=remcowesterhoud a=backport-action

# Description
Backport of #11034 to `stable/8.1`.

relates to #10978

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
zeebe-bors-camunda bot added a commit that referenced this pull request Nov 17, 2022
11035: [Backport stable/8.0] Resolve flaky shouldTriggerTimerTest r=remcowesterhoud a=backport-action

# Description
Backport of #11034 to `stable/8.0`.

relates to #10978

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
zeebe-bors-camunda bot added a commit that referenced this pull request Nov 18, 2022
11035: [Backport stable/8.0] Resolve flaky shouldTriggerTimerTest r=remcowesterhoud a=backport-action

# Description
Backport of #11034 to `stable/8.0`.

relates to #10978

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
zeebe-bors-camunda bot added a commit that referenced this pull request Nov 18, 2022
11035: [Backport stable/8.0] Resolve flaky shouldTriggerTimerTest r=remcowesterhoud a=backport-action

# Description
Backport of #11034 to `stable/8.0`.

relates to #10978

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
@remcowesterhoud remcowesterhoud added the version:8.1.4 Marks an issue as being completely or in parts released in 8.1.4 label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:8.1.4 Marks an issue as being completely or in parts released in 8.1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimerCatchEventTest.shouldTriggerTimer is flaky (again)
3 participants