-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gateway): don't log IllegalArgumentException as errors #11169
fix(gateway): don't log IllegalArgumentException as errors #11169
Conversation
@skayliu thank you for your contribution. 🎉 We'll have a look at your PR in the next few days. 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @skayliu! Thanks for the changes, I have tested it locally and it all seems to be working fine. I have one question about the changes though, and a small comment.
🔧 Please also add a testcase to the RequestMapperTest
protocol-impl/src/main/java/io/camunda/zeebe/protocol/impl/encoding/MsgPackConverter.java
Show resolved
Hide resolved
@remcowesterhoud, Done, please check this out. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @skayliu 🙇
bors merge
IllegalArgumentException get thrown when a user passes variables in their request which cannot be converted to message pack. Currently these are being logged as errors. Since this a fault by the user we should log these as debug.
538d938
to
69ae007
Compare
Hi, @remcowesterhoud, It seems to need to rebase to main. Done, Please try again, Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
11169: fix(gateway): don't log IllegalArgumentException as errors r=remcowesterhoud a=skayliu ## Description IllegalArgumentException get thrown when a user passes variables in their request which cannot be converted to message pack. Currently these are being logged as errors. Since this a fault by the user we should log these as debug. User input should not lead to reported errors, but user command should be rejected with a helpful message. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #9832 Co-authored-by: skayliu <skay463@163.com>
Build failed: |
bors retry |
Build succeeded: |
/backport |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-11169-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-11169-to-stable/8.0
git checkout -b backport-11169-to-stable/8.0
ancref=$(git merge-base 659571bbc2651a6a5728428745a457aabe411089 69ae007c7961a29395f428244a9d94a1426e6963)
git cherry-pick -x $ancref..69ae007c7961a29395f428244a9d94a1426e6963 |
Successfully created backport PR #11273 for |
11277: Backport 11169 to stable 8.0 r=remcowesterhoud a=remcowesterhoud ## Description <!-- Please explain the changes you made here. --> Manual backport of #11169 to stable 8.0 because of a merge conflicts in the `RequestMapperTest`. ## Related issues <!-- Which issues are closed by this PR or are related --> closes # Co-authored-by: skayliu <skay463@163.com>
Description
IllegalArgumentException get thrown when a user passes variables in their request which cannot be converted to message pack. Currently these are being logged as errors. Since this a fault by the user we should log these as debug.
User input should not lead to reported errors, but user command should be rejected with a helpful message.
Related issues
closes #9832
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.