Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky exporter test #11246

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Fix flaky exporter test #11246

merged 2 commits into from
Dec 12, 2022

Conversation

deepthidevaki
Copy link
Contributor

@deepthidevaki deepthidevaki commented Dec 12, 2022

Description

The flaky test failure was not reproducible. But by the failure description, it seems to be a race condition between updating the exported records and verifying the properties. The test was flaky because exporter 1 did not have all expected records. failCount is updated before the record is added to the exportedRecords. So it is possible that the property is asserted too early. To prevent it, wait until the condition is satisfied.

Related issues

closes #11078

The test was flaky because exporter 1 did not have all expected records. "failCount" is updated before the record is added to the exportedRecords. So it is possible that the property is asserted too early
@github-actions
Copy link
Contributor

Test Results

   964 files  ±    0     964 suites  ±0   1h 57m 44s ⏱️ + 9m 38s
8 032 tests +348  8 025 ✔️ +348  7 💤 ±0  0 ±0 
8 238 runs  +348  8 229 ✔️ +348  9 💤 ±0  0 ±0 

Results for commit e2ed393. ± Comparison against base commit 422d4f6.

Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@deepthidevaki
Copy link
Contributor Author

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit a1ab00a into main Dec 12, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the dd-11078-flaky-exporter branch December 12, 2022 13:31
@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-11246-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-11246-to-stable/8.0
git checkout -b backport-11246-to-stable/8.0
ancref=$(git merge-base 422d4f6307a5439f2f017aa0c7e91091799252d1 e2ed3939ed9c4fad3d1e0ae106715229be717aea)
git cherry-pick -x $ancref..e2ed3939ed9c4fad3d1e0ae106715229be717aea

@backport-action
Copy link
Collaborator

Backport failed for stable/8.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.1
git worktree add -d .worktree/backport-11246-to-stable/8.1 origin/stable/8.1
cd .worktree/backport-11246-to-stable/8.1
git checkout -b backport-11246-to-stable/8.1
ancref=$(git merge-base 422d4f6307a5439f2f017aa0c7e91091799252d1 e2ed3939ed9c4fad3d1e0ae106715229be717aea)
git cherry-pick -x $ancref..e2ed3939ed9c4fad3d1e0ae106715229be717aea

zeebe-bors-camunda bot added a commit that referenced this pull request Dec 13, 2022
11255: [Backport/stable/8.1] Fix flaky exporter test r=npepinpe a=deepthidevaki

Backport #11246

closes #1078

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this pull request Dec 14, 2022
11254: [Backport/stable/8.0] Fix flaky exporter test r=deepthidevaki a=deepthidevaki

## Description

Backport #11246 

closes #11078 


Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@Zelldon Zelldon added release/8.0.10 version:8.1.6 Marks an issue as being completely or in parts released in 8.1.6 labels Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:8.1.6 Marks an issue as being completely or in parts released in 8.1.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExporterDirectorTest.shouldRetryExportingOnException is flaky
4 participants