-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky exporter test #11246
Merged
Merged
Fix flaky exporter test #11246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was flaky because exporter 1 did not have all expected records. "failCount" is updated before the record is added to the exportedRecords. So it is possible that the property is asserted too early
npepinpe
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
bors merge |
Build succeeded: |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-11246-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-11246-to-stable/8.0
git checkout -b backport-11246-to-stable/8.0
ancref=$(git merge-base 422d4f6307a5439f2f017aa0c7e91091799252d1 e2ed3939ed9c4fad3d1e0ae106715229be717aea)
git cherry-pick -x $ancref..e2ed3939ed9c4fad3d1e0ae106715229be717aea |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.1
git worktree add -d .worktree/backport-11246-to-stable/8.1 origin/stable/8.1
cd .worktree/backport-11246-to-stable/8.1
git checkout -b backport-11246-to-stable/8.1
ancref=$(git merge-base 422d4f6307a5439f2f017aa0c7e91091799252d1 e2ed3939ed9c4fad3d1e0ae106715229be717aea)
git cherry-pick -x $ancref..e2ed3939ed9c4fad3d1e0ae106715229be717aea |
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The flaky test failure was not reproducible. But by the failure description, it seems to be a race condition between updating the exported records and verifying the properties. The test was flaky because exporter 1 did not have all expected records.
failCount
is updated before the record is added to theexportedRecords
. So it is possible that the property is asserted too early. To prevent it, wait until the condition is satisfied.Related issues
closes #11078