Add QA tests that verify CreateProcessInstanceWithResult responses

[korthout]

Description

These two cases failed recently due to a bug introduced with batch processing [1].

As this affected behavior visible to users, it makes sense to introduce QA integration tests that showcase that the CreateProcessInstanceWithResult can actually respond when the process instance is completed by another user command.

Related issues

relates to #11848

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

• The changes are backwards compatibility with previous versions
• If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

• There are unit/integration tests that verify all acceptance criterias of the issue
• New tests are written to ensure backwards compatibility with further versions
• The behavior is tested manually
• The change has been verified by a QA run
• The impact of the changes is verified by a benchmark

Documentation:

• The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
• If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

• Operate
• Tasklist
• Web Modeler
• Desktop Modeler
• Optimize

Please refer to our review guidelines.

[korthout]

Hi @berkaycanbc. There is no issue tracking this pull request, as the related issue is already closed when the bug was fixed. But, I still think it makes sense to add these test cases. Can you take a look when you have time?

Let me know if you have any questions, or if you want to have a look at them together.

[github-actions]

Test Results

1 015 files  +  1  1 015 suites  +1   1h 52m 15s ⏱️ - 4m 14s
8 049 tests  - 86  8 039 ✔️  - 86  10 💤 ±0  0 ❌ ±0 
8 255 runs   - 86  8 245 ✔️  - 86  10 💤 ±0  0 ❌ ±0 

Results for commit 892135a. ± Comparison against base commit 6c36841.

This pull request removes 699 and adds 613 tests. Note that renamed tests count towards both.

DmnEvaluationTest If successfully evaluated, the output ‑ Should return a message pack output[6] value={z=[1, 2, 3], y=true, x=1}
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[56] collection=[Left[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[57] collection=[Right[[B@1d3e5c4f], Left[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[58] collection=[Left[[B@1d3e5c4f], Right[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[59] collection=[Left[[B@1d3e5c4f], Left[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[60] collection=[Right[[B@1d3e5c4f], Right[[B@1d3e5c4f], Left[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[61] collection=[Right[[B@1d3e5c4f], Left[[B@1d3e5c4f], Right[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[62] collection=[Right[[B@1d3e5c4f], Left[[B@1d3e5c4f], Left[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[63] collection=[Left[[B@1d3e5c4f], Right[[B@1d3e5c4f], Right[[B@1d3e5c4f]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[64] collection=[Left[[B@1d3e5c4f], Right[[B@1d3e5c4f], Left[[B@1d3e5c4f]]
…

DmnEvaluationTest If successfully evaluated, the output ‑ Should return a message pack output[6] value={y=true, z=[1, 2, 3], x=1}
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[56] collection=[Left[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[57] collection=[Right[[B@5632b1e2], Left[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[58] collection=[Left[[B@5632b1e2], Right[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[59] collection=[Left[[B@5632b1e2], Left[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[60] collection=[Right[[B@5632b1e2], Right[[B@5632b1e2], Left[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[61] collection=[Right[[B@5632b1e2], Left[[B@5632b1e2], Right[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[62] collection=[Right[[B@5632b1e2], Left[[B@5632b1e2], Left[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[63] collection=[Left[[B@5632b1e2], Right[[B@5632b1e2], Right[[B@5632b1e2]]
EitherTest Streams of Eithers can be collected using .collector() ‑ Only Streams with Lefts are collected into a Left[64] collection=[Left[[B@5632b1e2], Right[[B@5632b1e2], Left[[B@5632b1e2]]
…

♻️ This comment has been updated with latest results.

[berkaycanbc]

@korthout

I also observed that previous related PR has tests that only cover general use case. Really nice that you added tests for actual cases that are observed by users. 🚀

❓ One additional question: do we have other cases where we can complete create process instance command? If so, it might be good to add test cases for them as well.

Approving it as I expect these are all the cases available.

[korthout]

do we have other cases where we can complete create process instance command?

👍 To be honest, I hadn't given much thought to this until I read this review comment. As a result, I added 892135a. Thanks for this great review hint! 🚀

@berkaycanbc Can you have another look?

[berkaycanbc]

@korthout Really nice that we covered all cases to complete a process! 🚀

Also, these test cases were clear references for me to see possible ways to complete a process. Thanks!

[korthout]

bors merge

[zeebe-bors-camunda]

Build succeeded:

• Test summary

[backport-action]

Successfully created backport PR for stable/8.0:

• [Backport stable/8.0] Add QA tests that verify CreateProcessInstanceWithResult responses #12072

[backport-action]

Successfully created backport PR for stable/8.1:

• [Backport stable/8.1] Add QA tests that verify CreateProcessInstanceWithResult responses #12073