Restore blacklist metric #12606
Merged
Restore blacklist metric #12606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On restart/recovery we need to restore the blacklist metric in order to report it always. Otherwise we will have gaps in the reports and it is not reliable, due to restarts and reseting of counters. Change counter to gauge, such it can be reset/set to a specific value based on the state.
|
Dashboard changes I would do after #12594 is merged, otherwise we get ugly merge conflicts. |
remcowesterhoud
approved these changes
May 1, 2023
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
May 1, 2023
12606: Restore blacklist metric r=remcowesterhoud a=Zelldon ## Description On restart/recovery we need to restore the blacklist metric in order to report it always. Otherwise, we will have gaps in the reports and it is not reliable, due to restarts and resetting of counters. Change counter to gauge, such that it can be reset/set to a specific value based on the state. See related comment #8263 (comment) <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> closes #8263 Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
Build failed: |
|
There is lots of networking issues with Maven today. Let's retry tomorrow. |
|
bors r+ |
|
Build succeeded: |
Zelldon
added
backport stable/8.0
backport stable/8.2
|
/backport |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-12606-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-12606-to-stable/8.0
git checkout -b backport-12606-to-stable/8.0
ancref=$(git merge-base d7a0344d28d7032ff689d2aa28c78d080034057f ffb030f3428eb21d8df61cd5edf10fde77550cac)
git cherry-pick -x $ancref..ffb030f3428eb21d8df61cd5edf10fde77550cac |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.1
git worktree add -d .worktree/backport-12606-to-stable/8.1 origin/stable/8.1
cd .worktree/backport-12606-to-stable/8.1
git checkout -b backport-12606-to-stable/8.1
ancref=$(git merge-base d7a0344d28d7032ff689d2aa28c78d080034057f ffb030f3428eb21d8df61cd5edf10fde77550cac)
git cherry-pick -x $ancref..ffb030f3428eb21d8df61cd5edf10fde77550cac |
|
Successfully created backport PR for |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
May 3, 2023
12643: [Backport stable/8.2] fix: brokers can list more than 255 backups r=deepthidevaki a=oleschoenburg Manual backport of #12621 to fix revapi merge conflicts. 12644: [Backport stable/8.2] Restore blacklist metric r=Zelldon a=backport-action # Description Backport of #12606 to `stable/8.2`. relates to #8263 Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com> Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
This was referenced May 3, 2023
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
May 3, 2023
12629: [Backport 8.1]: Introduce experimental SST partitioning r=remcowesterhoud a=Zelldon ## Description Backports #12483 <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> relates to #12033 12646: [Backport 8.1]: Restore blacklist metric r=remcowesterhoud a=Zelldon ## Description Backports #12606 Merge conflicts because of imports. ## Related issues closes #8263 Co-authored-by: Christopher Zell <zelldon91@googlemail.com> Co-authored-by: Christopher Kujawa (Zell) <zelldon91@googlemail.com>
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
May 3, 2023
12630: [Backport 8.0]: Introduce experimental SST partitioning r=remcowesterhoud a=Zelldon ## Description Backports #12483 <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> closes #12033 12645: [Backport 8.0]: Restore blacklist metric r=remcowesterhoud a=Zelldon ## Description Backports #12606 <!-- Please explain the changes you made here. --> The PR https://github.com/camunda/zeebe/pull/12306/files wasn't backported to 8.0, which caused some conflicts. I had to add the onRecovered method and call it in the ZeebeDbState. ## Related issues <!-- Which issues are closed by this PR or are related --> closes #8263 Co-authored-by: Christopher Zell <zelldon91@googlemail.com> Co-authored-by: Christopher Kujawa (Zell) <zelldon91@googlemail.com>
remcowesterhoud
added
release/8.0.14
version:8.2.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On restart/recovery we need to restore the blacklist metric in order to report it always. Otherwise, we will have gaps in the reports and it is not reliable, due to restarts and resetting of counters.
Change counter to gauge, such that it can be reset/set to a specific value based on the state.
See related comment #8263 (comment)
Related issues
closes #8263