[Backport stable/8.1] fix: do not retake backup if it already exists #12662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were only checking for backups taken by this node. However, there could be backups taken by another node. For example, after restore the checkpoint record is processed again, but it must not re-take the backup. To prevent that, we should check for all backups with the given backup id. (cherry picked from commit a886d80)
Updated the test to remove mocking of InProgressBackup. The existing test was updated to use list instead of getStatus to find duplicate backups. (cherry picked from commit 8763717)
Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com> (cherry picked from commit 65e08d9)
|
Manual backport because of merge conflict in |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
May 4, 2023
12662: [Backport stable/8.1] fix: do not retake backup if it already exists r=oleschoenburg a=deepthidevaki Backport of #12626 to stable/8.1. relates to #12623 Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com> Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@users.noreply.github.com>
|
Build failed: |
|
@deepthidevaki Looks like I was too fast, there are compilation errors. bors r- |
|
Oops. I'm checking it. |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12626 to stable/8.1.
relates to #12623