Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(broker): reject requests larger than max message size #12676

Merged
merged 4 commits into from
May 8, 2023

Conversation

deepthidevaki
Copy link
Contributor

@deepthidevaki deepthidevaki commented May 5, 2023

Description

Reject requests larger than max message size in CommandApi. Previously this was written to logstream, and rejected during processing, which is unnecessary. This also caused issues because, the engine could not write rejection record to the logstream.

Related issues

closes #12591

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

Please refer to our review guidelines.

@deepthidevaki deepthidevaki marked this pull request as ready for review May 8, 2023 08:41
@deepthidevaki deepthidevaki added backport stable/8.0 backport stable/8.2 Backport a pull request to 8.2.x and removed backport stable/8.0 labels May 8, 2023
Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Though I don't think this is enough to close the original issue. A rejection could potentially be larger than the original command, leading to the same problem 😄 Or some other case we didn't think of

@deepthidevaki
Copy link
Contributor Author

Though I don't think this is enough to close the original issue. A rejection could potentially be larger than the original command, leading to the same problem smile Or some other case we didn't think of

True. I have created follow up issue #12699. This is to be handled in the engine.

@deepthidevaki
Copy link
Contributor Author

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit a653eb8 into main May 8, 2023
41 of 42 checks passed
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the dd-12591-batchsize branch May 8, 2023 15:15
@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.2:

zeebe-bors-camunda bot added a commit that referenced this pull request May 22, 2023
12700: [Backport stable/8.2] fix(broker): reject requests larger than max message size r=deepthidevaki a=backport-action

# Description
Backport of #12676 to `stable/8.2`.

relates to #12591

Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@lenaschoenburg lenaschoenburg added the version:8.2.6 Marks an issue as being completely or in parts released in 8.2.6 label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable/8.2 Backport a pull request to 8.2.x version:8.2.6 Marks an issue as being completely or in parts released in 8.2.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8.2.3 Degradation: Creating an oversized BPMN causes unrecoverable failure
4 participants