-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(broker): reject requests larger than max message size #12676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Though I don't think this is enough to close the original issue. A rejection could potentially be larger than the original command, leading to the same problem 😄 Or some other case we didn't think of
True. I have created follow up issue #12699. This is to be handled in the engine. |
bors merge |
Build succeeded: |
Successfully created backport PR for |
Description
Reject requests larger than max message size in CommandApi. Previously this was written to logstream, and rejected during processing, which is unnecessary. This also caused issues because, the engine could not write rejection record to the logstream.
Related issues
closes #12591
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.
Please refer to our review guidelines.