Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove unnecessary commit for old go compat #12724

Merged
merged 1 commit into from
May 9, 2023

Conversation

npepinpe
Copy link
Member

@npepinpe npepinpe commented May 9, 2023

Description

Removes an unnecessary commit, as we don't use gocompat to generate a new compatibility file anymore, so we can simply drop this commit which has nothing to do.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

Please refer to our review guidelines.

Removes an unnecessary commit, as we don't use gocompat to generate a
new compatibility file anymore, so we can simply drop this commit which
has nothing to do.
@npepinpe npepinpe requested a review from korthout May 9, 2023 13:34
@npepinpe
Copy link
Member Author

npepinpe commented May 9, 2023

Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @npepinpe ❤️

LGTM 👍

@npepinpe
Copy link
Member Author

npepinpe commented May 9, 2023

bors merge

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit ffb2df9 into main May 9, 2023
37 checks passed
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the np-fix-release-gocompat branch May 9, 2023 14:53
@npepinpe npepinpe added backport stable/8.0 backport stable/8.2 Backport a pull request to 8.2.x labels May 24, 2023
@npepinpe
Copy link
Member Author

/backport

@npepinpe
Copy link
Member Author

npepinpe commented May 24, 2023

/backport

Seems like this caused some errors for the backport action: https://github.com/camunda/zeebe/actions/runs/5066659671

@npepinpe
Copy link
Member Author

/backport

@backport-action
Copy link
Collaborator

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-12724-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-12724-to-stable/8.0
git checkout -b backport-12724-to-stable/8.0
ancref=$(git merge-base d6d93588789b8a1aee68a42bd8496543cf7bf483 08712b9789d68db77c77a9dec201a8ac2bf06ea8)
git cherry-pick -x $ancref..08712b9789d68db77c77a9dec201a8ac2bf06ea8

@backport-action
Copy link
Collaborator

Backport failed for stable/8.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.1
git worktree add -d .worktree/backport-12724-to-stable/8.1 origin/stable/8.1
cd .worktree/backport-12724-to-stable/8.1
git checkout -b backport-12724-to-stable/8.1
ancref=$(git merge-base d6d93588789b8a1aee68a42bd8496543cf7bf483 08712b9789d68db77c77a9dec201a8ac2bf06ea8)
git cherry-pick -x $ancref..08712b9789d68db77c77a9dec201a8ac2bf06ea8

@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.2:

zeebe-bors-camunda bot added a commit that referenced this pull request May 24, 2023
12852: [Backport stable/8.2] build: remove unnecessary commit for old go compat r=npepinpe a=backport-action

# Description
Backport of #12724 to `stable/8.2`.

relates to 

Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com>
@lenaschoenburg lenaschoenburg added the version:8.2.6 Marks an issue as being completely or in parts released in 8.2.6 label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable/8.2 Backport a pull request to 8.2.x version:8.2.6 Marks an issue as being completely or in parts released in 8.2.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants