feat(cluster): impove error message when bootstrap channel fails

[deepthidevaki]

Description

A cluster was reporting following error:

RaftServer{raft-partition-partition-3} - ConfigureRequest{...} to 0 failed: java.util.concurrent.CompletionException: java.net.ConnectException: Failed to connect channel for address zeebe-0.zeebe-broker-service.a7151101-b5c5-4415-8970-684b97779c02-zeebe.svc.cluster.local:26502

This has no information to help debug. This PR adds the resolved IP and error to this message.

Related issues

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

• The changes are backwards compatibility with previous versions
• If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

• There are unit/integration tests that verify all acceptance criterias of the issue
• New tests are written to ensure backwards compatibility with further versions
• The behavior is tested manually
• The change has been verified by a QA run
• The impact of the changes is verified by a benchmark

Documentation:

• The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
• If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

• Operate
• Tasklist
• Web Modeler
• Desktop Modeler
• Optimize

Please refer to our review guidelines.

[Zelldon]

Thanks @deepthidevaki :)

[Zelldon]

Lets follow our error guidelines :) https://github.com/camunda/zeebe/wiki/Error-Guidelines

Suggested change

	String.format(
	"Failed to connect channel for address %s (resolved: %s) : %s",
	address, address.address(), onConnect.cause())));
	String.format(
	"Expected to create channel to %s (resolved: %s), but failed with : %s",
	address, address.address(), onConnect.cause())));

[deepthidevaki]

I find it unnecessarily verbose. When we say "Failed to connect channel" It is already clear that it is expected to connect channel. Right? Besides the error guidelines doesn't require to use the exact same format.

[Zelldon]

I prefer a consistent format, even if it is a bit more verbose it is always clear what is expected and what happened with additional context. As far as I know, we agreed on that a while ago. If you disagree, feel free to bring it up in a team discussion.

[Zelldon]

BTW go ahead to merge it anyway, nothing what should block you (I already accepted)

[deepthidevaki]

bors merge

[zeebe-bors-camunda]

Build failed:

• Test summary

[deepthidevaki]

bors merge

[zeebe-bors-camunda]

Build succeeded:

• Test summary

[backport-action]

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-12760-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-12760-to-stable/8.0
git checkout -b backport-12760-to-stable/8.0
ancref=$(git merge-base 6929e1c28d25aac8493b0f09650ddb8d17e0344f 5d8f9d314b68b79f74323da0f4a1a9d8db08b13b)
git cherry-pick -x $ancref..5d8f9d314b68b79f74323da0f4a1a9d8db08b13b

[backport-action]

Backport failed for stable/8.1, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.1
git worktree add -d .worktree/backport-12760-to-stable/8.1 origin/stable/8.1
cd .worktree/backport-12760-to-stable/8.1
git checkout -b backport-12760-to-stable/8.1
ancref=$(git merge-base 6929e1c28d25aac8493b0f09650ddb8d17e0344f 5d8f9d314b68b79f74323da0f4a1a9d8db08b13b)
git cherry-pick -x $ancref..5d8f9d314b68b79f74323da0f4a1a9d8db08b13b

[backport-action]

Backport failed for stable/8.2, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.2
git worktree add -d .worktree/backport-12760-to-stable/8.2 origin/stable/8.2
cd .worktree/backport-12760-to-stable/8.2
git checkout -b backport-12760-to-stable/8.2
ancref=$(git merge-base 6929e1c28d25aac8493b0f09650ddb8d17e0344f 5d8f9d314b68b79f74323da0f4a1a9d8db08b13b)
git cherry-pick -x $ancref..5d8f9d314b68b79f74323da0f4a1a9d8db08b13b