-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specific error codes for logstream write failure #12910
Conversation
broker/src/main/java/io/camunda/zeebe/broker/transport/commandapi/CommandApiRequestHandler.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @deepthidevaki, I think it's a good idea to return an Either
from the Sequencer.
I've left some optional remarks, nothing else.
logstreams/src/main/java/io/camunda/zeebe/logstreams/log/LogStreamWriter.java
Outdated
Show resolved
Hide resolved
stream-platform/src/main/java/io/camunda/zeebe/stream/impl/ProcessingStateMachine.java
Outdated
Show resolved
Hide resolved
broker/src/main/java/io/camunda/zeebe/broker/transport/commandapi/CommandApiRequestHandler.java
Show resolved
Hide resolved
broker/src/main/java/io/camunda/zeebe/broker/transport/ErrorResponseWriter.java
Outdated
Show resolved
Hide resolved
@oleschoenburg I have applied your comments. |
2f6fc08
to
0ca6cd5
Compare
bors merge |
Build succeeded: |
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.2
git worktree add -d .worktree/backport-12910-to-stable/8.2 origin/stable/8.2
cd .worktree/backport-12910-to-stable/8.2
git checkout -b backport-12910-to-stable/8.2
ancref=$(git merge-base 7c31e9ea6596e7f6da16aada6139be536056997a 0ca6cd55d35a3ad7c958da3fc5ffea4977ad3b80)
git cherry-pick -x $ancref..0ca6cd55d35a3ad7c958da3fc5ffea4977ad3b80 |
Description
LogstreamWriter#tryWrite returns specific error codes. If the sequencer is full, then the CommandApi can return a partition-leader-mismatch error code so that the gateway can retry the request. Other errors are mapped to internal error and logged at debug level.
Related issues
closes #12780
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.
Please refer to our review guidelines.