Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(engine): thread-safe transient subscription state #13072

Merged
merged 4 commits into from
Jun 15, 2023

Commits on Jun 12, 2023

  1. feat(engine): thread-safe holder of pending subscriptions

    This changes the existing transient state holder to be thread safe.
    Allows for future changes where we need concurrent read and write
    operations.
    lenaschoenburg committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    839744f View commit details
    Browse the repository at this point in the history
  2. refactor(engine): simplify pending message subscription state

    The previous class hierarchy was a bit confusing. With these changes
    here, the `DbMessageSubscriptionState` is responsible for all state
    changes. When necessary, it reads from and writes to the transient state
    directly.
    
    This also adjusts names and package paths to indicate that reading and
    writing transient state is not a mutable operation.
    lenaschoenburg committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    d928ba2 View commit details
    Browse the repository at this point in the history
  3. refactor(engine): simplify pending process message subscription state

    The previous class hierarchy was a bit confusing. With these changes
    here, the `DbProcessMessageSubscriptionState` is responsible for all
    state changes. When necessary, it reads from and writes to the transient
    state directly.
    
    This also adjusts names and package paths to indicate that reading and
    writing transient state is not a mutable operation.
    lenaschoenburg committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    f8a7dc4 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. refactor(engine): use appropriate methods when updating transient state

    Although the implementation is equivalent, using `update` instead of
    `add` is clearer.
    lenaschoenburg committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    6b78c7c View commit details
    Browse the repository at this point in the history