Performance test for large state and stable performance #13121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zelldon
force-pushed
the
zell-performance-test-engine
branch
2 times, most recently
from
270a515
to
0ffbbe4
Compare
In order to be able to easily exchange or replace the StreamProcessorRule a new interface is introduced, which abstracts the writing of commands away. The implementation can be completelty separated and change without breaking the test clients.
Extract class ProcessingExporterTransistor from EngineRule in order to be used by Performance Test
Create TestInterPartitionCommandSender.java in util package, in order to be used by both EngineRule and performance tests.
Zelldon
force-pushed
the
zell-performance-test-engine
branch
from
0ffbbe4
to
50f23ca
Compare
|
Example execution with |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Example with SST partitioning disabled |
* use separated ProcessingExporterTransistor * use separated TestInterPartitionCommandSender.java * remove unused ReprocessingCompletedListener
Create new JMH test in order to verify stable performance on large state. * Create helper class TestEngine.java in order to simplify and encapsulate the engine setup. * Create record TestContext.java which contains infrastructure related dependencies, which might be shared by multiple engines. * Add JMH benchmark which allows to measure how the throughput looks like of process instance creation. * Use Seconds as output unit, for better representation and understandability * Use measure timeunit seconds this means the creation of PI is tried as often as possible in one second * Increase warm up and measure iterations * Reset the RecordingExporter in between, in order to avoid slowing down the benchmark * State is created on setup, to make sure we always create the same amount of data
Zelldon
force-pushed
the
zell-performance-test-engine
branch
from
50f23ca
to
a53aa52
Compare
lenaschoenburg
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Great job @Zelldon 🚀
Most of my comments are a bit nit-picky and actually unrelated to the JMH benchmark.
❓ I was only able to run these once through IntelliJ, every run after the first is seemingly stuck in the warmup phase. I guess that's not the case for you?
engine/src/test/java/io/camunda/zeebe/engine/util/ProcessingExporterTransistor.java
Outdated
Show resolved
Hide resolved
engine/src/test/java/io/camunda/zeebe/engine/util/ProcessingExporterTransistor.java
Show resolved
Hide resolved
engine/src/test/java/io/camunda/zeebe/engine/util/EngineRule.java
Outdated
Show resolved
Hide resolved
engine/src/test/java/io/camunda/zeebe/engine/util/EngineRule.java
Outdated
Show resolved
Hide resolved
engine/src/test/java/io/camunda/zeebe/engine/perf/TestContext.java
Outdated
Show resolved
Hide resolved
|
bors r+ |
| /** | ||
| * Containing infrastructure related dependencies which might be shared between TestEngines. | ||
| * | ||
| * @param actorScheduler the scheduler which is used during tests |
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags Note
| * Containing infrastructure related dependencies which might be shared between TestEngines. | ||
| * | ||
| * @param actorScheduler the scheduler which is used during tests | ||
| * @param temporaryFolder the temporary folder where the log and runtime is written to |
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags Note
| * | ||
| * @param actorScheduler the scheduler which is used during tests | ||
| * @param temporaryFolder the temporary folder where the log and runtime is written to | ||
| * @param autoCloseableRule a collector of all to managed resources, which should be cleaned up |
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags Note
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@oleschoenburg I created this PR in order to get the first increment merged and to not overwhelm you with more changes. Most of the changes here are refactorings and preparation for the JMH test, plus of course the JMH test itself.
I applied already several things we have discussed, like creation of large state in setup phase, keeping the test in engine module etc. In an upcoming PR I will execute the JMH benchmark inside a unit test, which is executed in a separate CI job, please see related comment.
Related issues
related to #12241