fix(dist): remove Spring Boot warning around commons-logging #13300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring displays a prominent warning when using different versions of `commons-logging`. They use their own variant, `spring-jcl`, and importing `commons-logging` conflicts with this. We pull in `commons-logging` via the Opensearch and Elasticsearch exporters respectively. I have not noticed any issues with logging when removing, and followed the suggestion from Spring themselves, see: spring-projects/spring-data-elasticsearch#1993
|
Requesting a review from the ZPA team as this may affect the exporters, though I didn't notice anything 🤷 |
remcowesterhoud
approved these changes
Jul 4, 2023
|
Build succeeded: |
14 tasks
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Jul 18, 2023
13511: Bump Spring Boot to latest 3.1.x r=npepinpe a=npepinpe ## Description Manually bump Spring Boot to the latest version to resolve some outstanding high CVEs. At the same time, back port #13300 to fix a Spring warning. Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com> Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Jul 18, 2023
13511: Bump Spring Boot to latest 3.1.x r=npepinpe a=npepinpe ## Description Manually bump Spring Boot to the latest version to resolve some outstanding high CVEs. At the same time, back port #13300 to fix a Spring warning. Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com> Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spring displays a prominent warning when using different versions of
commons-logging. They use their own variant,spring-jcl, and importingcommons-loggingconflicts with this.We pull in
commons-loggingvia the Opensearch and Elasticsearch exporters respectively. I have not noticed any issues with logging when removing, and followed the suggestion from Spring themselves, see:spring-projects/spring-data-elasticsearch#1993
Related issues
closes #13299
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.
Please refer to our review guidelines.