Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse already created checksum collections on persist #14184

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Reuse already created checksum collections on persist #14184

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d3a703
feat: support update checksum collection from bytes
Zelldon Sep 6, 2023
fc59c89
feat: support checksum collection on persist new snapshot
Zelldon Sep 6, 2023
bcc958e
refactor: use new perst method
Zelldon Sep 6, 2023
f7d0555
refactor: directly persist given checksum collection
Zelldon Sep 6, 2023
0638271
style: apply style guide
Zelldon Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion snapshot/src/main/java/io/camunda/zeebe/snapshots/impl/SnapshotChecksum.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ private static boolean isNotMetadataFile(final Path file) {

public static void persist(final Path checksumPath, final ImmutableChecksumsSFV checksum)
throws IOException {
try(final var stream = new FileOutputStream(checksumPath.toFile())) {
try (final var stream = new FileOutputStream(checksumPath.toFile())) {
Copy link
Member

@npepinpe npepinpe Sep 6, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups 🙈 my bad

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah :D seems to be from the other PR :D

checksum.write(stream);
}
}
Expand Down