Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(engine): apply MT migration in chunks #16139

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

npepinpe
Copy link
Member

Description

This PR applies the migration transaction split to all multi tenancy migrations in 8.3. No new tests added mostly because we've shown this fix only mitigates things, so we will do that in a follow up PR.

Related issues

related to #14975

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

Please refer to our review guidelines.

@npepinpe npepinpe added the backport main Forward-port a pull request to main label Jan 30, 2024
@lenaschoenburg lenaschoenburg added the backport stable/8.4 Backport a pull request to 8.4.x label Jan 30, 2024
@lenaschoenburg lenaschoenburg added this pull request to the merge queue Jan 30, 2024
Merged via the queue into stable/8.3 with commit 3a8cf12 Jan 30, 2024
31 of 33 checks passed
@lenaschoenburg lenaschoenburg deleted the np-oom-migrations-8.3 branch January 30, 2024 10:32
@backport-action
Copy link
Collaborator

Backport failed for main, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin main
git worktree add -d .worktree/backport-16139-to-main origin/main
cd .worktree/backport-16139-to-main
git checkout -b backport-16139-to-main
ancref=$(git merge-base 1e32958c3318f4c48c930479b03d39f0136c129f d6a6aa35fc8715581fdbe6ab270d40950bcf6fd0)
git cherry-pick -x $ancref..d6a6aa35fc8715581fdbe6ab270d40950bcf6fd0

@backport-action
Copy link
Collaborator

Backport failed for stable/8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.4
git worktree add -d .worktree/backport-16139-to-stable/8.4 origin/stable/8.4
cd .worktree/backport-16139-to-stable/8.4
git checkout -b backport-16139-to-stable/8.4
ancref=$(git merge-base 1e32958c3318f4c48c930479b03d39f0136c129f d6a6aa35fc8715581fdbe6ab270d40950bcf6fd0)
git cherry-pick -x $ancref..d6a6aa35fc8715581fdbe6ab270d40950bcf6fd0

@npepinpe
Copy link
Member Author

We might not have merged the other parts yet 😄 Let's try after they are merged in the respective branches

@npepinpe
Copy link
Member Author

/backport

@backport-action
Copy link
Collaborator

Successfully created backport PR for main:

@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.4:

@npepinpe npepinpe added the version:8.3.6 Label that represents issues released on verions 8.3.6 label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport main Forward-port a pull request to main backport stable/8.4 Backport a pull request to 8.4.x version:8.3.6 Label that represents issues released on verions 8.3.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants