Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): remove extra unnecessary delete #16153

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

npepinpe
Copy link
Member

Description

This PR removes an extra deleteExisting which breaks inconsistency checks.

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

Please refer to our review guidelines.

Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

@npepinpe npepinpe added this pull request to the merge queue Jan 30, 2024
Merged via the queue into stable/8.3 with commit b48522e Jan 30, 2024
29 checks passed
@npepinpe npepinpe deleted the np-remove-extra-delete branch January 30, 2024 16:50
@npepinpe npepinpe added the version:8.3.6 Label that represents issues released on verions 8.3.6 label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:8.3.6 Label that represents issues released on verions 8.3.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants