-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporter can soft pause and resume #16345
Conversation
0bfb0d8
to
cfe5c99
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Awesome. I like the behavior of consecutive calls of pause vs soft-pause, and resume always resumes full exporting, no matter if it was soft paused or hard paused. 👍
❌ I have only one main comment. The exporter director should be able to start with phase soft-paused if it was soft-paused before restart. You can do it in a follow up PR. If so please create an issue for it and link it here for transparency.
Other comments are minor - like improvements to tests and documentation. Please address them in this PR itself.
broker/src/main/java/io/camunda/zeebe/broker/exporter/stream/ExporterDirector.java
Outdated
Show resolved
Hide resolved
broker/src/test/java/io/camunda/zeebe/broker/exporter/stream/ExporterContainerTest.java
Outdated
Show resolved
Hide resolved
broker/src/test/java/io/camunda/zeebe/broker/exporter/stream/ExporterDirectorPauseTest.java
Outdated
Show resolved
Hide resolved
broker/src/test/java/io/camunda/zeebe/broker/exporter/stream/ExporterDirectorPauseTest.java
Outdated
Show resolved
Hide resolved
broker/src/main/java/io/camunda/zeebe/broker/exporter/stream/ExporterDirector.java
Outdated
Show resolved
Hide resolved
broker/src/main/java/io/camunda/zeebe/broker/exporter/stream/ExporterPhase.java
Outdated
Show resolved
Hide resolved
broker/src/test/java/io/camunda/zeebe/broker/exporter/stream/ExporterContainerTest.java
Outdated
Show resolved
Hide resolved
cfe5c99
to
d95ad7e
Compare
d95ad7e
to
adc1dba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
/backport |
Successfully created backport PR for |
Successfully created backport PR for |
Successfully created backport PR for |
# Description Backport of #16345 to `stable/8.4`. relates to #16642 #16344 original author: @rodrigo-lourenco-lopes
/backport |
Git push to origin failed for stable/8.3 with exitcode 1 |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.4
git worktree add -d .worktree/backport-16345-to-stable/8.4 origin/stable/8.4
cd .worktree/backport-16345-to-stable/8.4
git switch --create backport-16345-to-stable/8.4
git cherry-pick -x ce0234a6de7451e147a8981262aad60f452c337e 3a123e4e7763ee11565044764288caf74a6db462 adc1dba80868c3cbacb57d59ac5425798223a593 |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.5
git worktree add -d .worktree/backport-16345-to-stable/8.5 origin/stable/8.5
cd .worktree/backport-16345-to-stable/8.5
git switch --create backport-16345-to-stable/8.5
git cherry-pick -x ce0234a6de7451e147a8981262aad60f452c337e 3a123e4e7763ee11565044764288caf74a6db462 adc1dba80868c3cbacb57d59ac5425798223a593 |
# Description Backport of #16345 to `stable/8.3`. relates to #16642 #16344 original author: @rodrigo-lourenco-lopes
# Description Backport of #16345 to `stable/8.2`. relates to #16642 #16344 original author: @rodrigo-lourenco-lopes
Description
Exporter can soft pause and resume. This means if the exporter is soft paused, we keep exporting the records without updating the exporter state. upon resuming The exporter state is updated with the position and metadata of the last exported record.
The feature to persist the soft paused state will be implemented in this issue #16642
Related issues
closes #16344
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.
Please refer to our review guidelines.