Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporter can soft pause and resume #16345

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

rodrigo-lourenco-lopes
Copy link
Contributor

@rodrigo-lourenco-lopes rodrigo-lourenco-lopes commented Feb 14, 2024

Description

Exporter can soft pause and resume. This means if the exporter is soft paused, we keep exporting the records without updating the exporter state. upon resuming The exporter state is updated with the position and metadata of the last exported record.

The feature to persist the soft paused state will be implemented in this issue #16642

Related issues

closes #16344

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

Please refer to our review guidelines.

Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Awesome. I like the behavior of consecutive calls of pause vs soft-pause, and resume always resumes full exporting, no matter if it was soft paused or hard paused. 👍

❌ I have only one main comment. The exporter director should be able to start with phase soft-paused if it was soft-paused before restart. You can do it in a follow up PR. If so please create an issue for it and link it here for transparency.

Other comments are minor - like improvements to tests and documentation. Please address them in this PR itself.

@romansmirnov romansmirnov added the component/zeebe Related to the Zeebe component/team label Mar 5, 2024
Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rodrigo-lourenco-lopes rodrigo-lourenco-lopes added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit e5b1f68 Mar 11, 2024
30 checks passed
@rodrigo-lourenco-lopes rodrigo-lourenco-lopes deleted the rl-exporter-can-soft-pause branch March 11, 2024 13:01
@rodrigo-lourenco-lopes rodrigo-lourenco-lopes added backport stable/8.2 Backport a pull request to 8.2.x backport stable/8.3 Backport a pull request to 8.3.x backport stable/8.4 Backport a pull request to 8.4.x labels Apr 25, 2024
@rodrigo-lourenco-lopes
Copy link
Contributor Author

/backport

@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.2:

@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.3:

@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.4:

github-merge-queue bot pushed a commit that referenced this pull request Apr 25, 2024
# Description
Backport of #16345 to `stable/8.4`.

relates to #16642 #16344
original author: @rodrigo-lourenco-lopes
@rodrigo-lourenco-lopes rodrigo-lourenco-lopes added the backport stable/8.5 Backport a pull request to stable/8.5 label Apr 25, 2024
@rodrigo-lourenco-lopes rodrigo-lourenco-lopes removed the backport stable/8.2 Backport a pull request to 8.2.x label Apr 25, 2024
@rodrigo-lourenco-lopes
Copy link
Contributor Author

/backport

@backport-action
Copy link
Collaborator

Git push to origin failed for stable/8.3 with exitcode 1

@backport-action
Copy link
Collaborator

Backport failed for stable/8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/8.4
git worktree add -d .worktree/backport-16345-to-stable/8.4 origin/stable/8.4
cd .worktree/backport-16345-to-stable/8.4
git switch --create backport-16345-to-stable/8.4
git cherry-pick -x ce0234a6de7451e147a8981262aad60f452c337e 3a123e4e7763ee11565044764288caf74a6db462 adc1dba80868c3cbacb57d59ac5425798223a593

@backport-action
Copy link
Collaborator

Backport failed for stable/8.5, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/8.5
git worktree add -d .worktree/backport-16345-to-stable/8.5 origin/stable/8.5
cd .worktree/backport-16345-to-stable/8.5
git switch --create backport-16345-to-stable/8.5
git cherry-pick -x ce0234a6de7451e147a8981262aad60f452c337e 3a123e4e7763ee11565044764288caf74a6db462 adc1dba80868c3cbacb57d59ac5425798223a593

github-merge-queue bot pushed a commit that referenced this pull request Apr 25, 2024
# Description
Backport of #16345 to `stable/8.3`.

relates to #16642 #16344
original author: @rodrigo-lourenco-lopes
@rodrigo-lourenco-lopes rodrigo-lourenco-lopes added backport stable/8.2 Backport a pull request to 8.2.x and removed backport stable/8.5 Backport a pull request to stable/8.5 labels Apr 26, 2024
github-merge-queue bot pushed a commit that referenced this pull request Apr 26, 2024
# Description
Backport of #16345 to `stable/8.2`.

relates to #16642 #16344
original author: @rodrigo-lourenco-lopes
@Zelldon Zelldon added version:8.2.27 Marks an issue as being completely or in parts released in 8.2.27 version:8.4.7 Marks an issue as being completely or in parts released in 8.4.7 version:8.3.11 Marks an issue as being completely or in parts released in 8.3.11 version:8.5.0 labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable/8.2 Backport a pull request to 8.2.x backport stable/8.3 Backport a pull request to 8.3.x backport stable/8.4 Backport a pull request to 8.4.x component/zeebe Related to the Zeebe component/team version:8.2.27 Marks an issue as being completely or in parts released in 8.2.27 version:8.3.11 Marks an issue as being completely or in parts released in 8.3.11 version:8.4.7 Marks an issue as being completely or in parts released in 8.4.7 version:8.5.0 Label that represents issues released on verions 8.5.0.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporter Director can Soft Pause (And Resume)
6 participants