Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[forwardport stable/8.3] Allow decision requirements in column family 49 #16420

Merged
merged 3 commits into from Feb 16, 2024
Merged

[forwardport stable/8.3] Allow decision requirements in column family 49 #16420

merged 3 commits into from Feb 16, 2024

Commits on Feb 16, 2024

  1. test: surface bug by changing id 

    This test case was not surfacing a bug due to usage of a specific
user-defined string as the decisionRequirementsId. This meant that the
correct data did not trigger the false positive where it would be
attempted to be moved.

(cherry picked from commit 7bdbf0f)
    @korthout
    korthout committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    0df2721 View commit details
    Browse the repository at this point in the history

  2. fix: move data that is not a drg 

    Previously, this code tried to move the data if it did not match the
processInstanceKeyByProcessDefinitionKey but actually it should move it
when it does match that.

another way to look at it, is that it should leave entries that match
the decisionRequirementsIdAndVersion key should be left alone because
they belong in this column family. Only entries that cannot be matched
to the decisionRequirementsIdAndVersion should be moved.

(cherry picked from commit 7f64ab4)
    @korthout
    korthout committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    a3f71ee View commit details
    Browse the repository at this point in the history

  3. test: expand test case to show data is correct 

    Adds another assertion to verify that the data that is not moved by the
corrector is the entries that we expect to stay in the column family
(i.e. the correct data)

(cherry picked from commit 94a79c7)
    @korthout
    korthout committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    7d4ee77 View commit details
    Browse the repository at this point in the history