Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not fail retry of member join operation #16907

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

deepthidevaki
Copy link
Contributor

Description

If the broker restarts while applying the operation, it might be in state joining. When the operation is reapplied after restart, it should not fail.

Related issues

closes #16870

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

Please refer to our review guidelines.

@deepthidevaki deepthidevaki added the backport stable/8.4 Backport a pull request to 8.4.x label Mar 15, 2024
@github-actions github-actions bot added the component/zeebe Related to the Zeebe component/team label Mar 15, 2024
If the broker restarts while applying the operation, it
might be in state joining. When the operation is reapplied
after restart, it should not fail.
Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 Since member join is a noop operation I'm actually suprised that we ran into this edge case at all. The timing for this must be really tight.

Change makes sense to me, it also aligns it with the other operations 👍

@deepthidevaki deepthidevaki added this pull request to the merge queue Mar 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 15, 2024
@deepthidevaki deepthidevaki added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit 93651a2 Mar 15, 2024
31 checks passed
@deepthidevaki deepthidevaki deleted the dd-16870-retry-member-join branch March 15, 2024 11:51
@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.4:

github-merge-queue bot pushed a commit that referenced this pull request Mar 21, 2024
…#16913)

# Description
Backport of #16907 to `stable/8.4`.

relates to #16870
original author: @deepthidevaki
@lenaschoenburg lenaschoenburg added the version:8.4.6 Marks an issue as being completely or in parts released in 8.4.6 label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable/8.4 Backport a pull request to 8.4.x component/zeebe Related to the Zeebe component/team version:8.4.6 Marks an issue as being completely or in parts released in 8.4.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broker scaling up is stuck in the operation adding a new broker
3 participants