Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge spring-client and spring-zeebe-sdk #17387

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

ana-vinogradova-camunda
Copy link
Contributor

Description

Merge SpringBoot starter SDK and Spring Client into the same subfolder. This merge is not affecting users.
We are keeping spring-boot-starter-camunda-sdk at root, as this is the start of the common camunda sdk to provide access to the general C8 REST API. I removed the zeebe-client-spring module and integrate the classes into spring-boot-starter-camunda-sdk

Related issues

closes #17339

@github-actions github-actions bot added component/zeebe Related to the Zeebe component/team component/operate Related to the Operate component/team labels Apr 9, 2024
@ana-vinogradova-camunda ana-vinogradova-camunda force-pushed the 17339-merge-spring-starter-and-spring-client branch from 67bedc4 to e734222 Compare April 9, 2024 14:38
@ana-vinogradova-camunda ana-vinogradova-camunda marked this pull request as ready for review April 9, 2024 14:53
Copy link
Contributor

@megglos megglos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Test Results

974 tests  ±0   938 ✅ ±0   2h 45m 14s ⏱️ + 17m 53s
170 suites ±0    36 💤 ±0 
170 files   ±0     0 ❌ ±0 

Results for commit bbbcfdf. ± Comparison against base commit 7126f05.

@nicpuppa nicpuppa added this pull request to the merge queue Apr 11, 2024
Merged via the queue into main with commit c52bf3c Apr 11, 2024
41 checks passed
@nicpuppa nicpuppa deleted the 17339-merge-spring-starter-and-spring-client branch April 11, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/operate Related to the Operate component/team component/zeebe Related to the Zeebe component/team version:8.6.0-alpha1 Label that represents issues released on verions 8.6.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge SpringBoot starter SDK and Spring Client
4 participants