Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align deployment rejection message for DMN resources #17475

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Align deployment rejection message for DMN resources #17475

merged 1 commit into from
Apr 18, 2024

Conversation

berkaycanbc
Copy link
Contributor

Description

Included the resource name in the rejection message of DMN validation error. Also, updated the related test to verify the expected behaviour.

Related issues

closes #8806

@github-actions github-actions bot added the component/zeebe Related to the Zeebe component/team label Apr 15, 2024
megglos
megglos approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@megglos megglos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love quick fixes and I cannot lie! Commitlint isn't happy with the scope, pre-approving so you can merge after resolving it.

@berkaycanbc berkaycanbc force-pushed the bcan-8806-align-deployment-rejection-message-for-DMN-resources branch from 91a67a6 to 1ef7611 Compare April 16, 2024 08:05
@berkaycanbc berkaycanbc added this pull request to the merge queue Apr 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2024
@megglos megglos enabled auto-merge April 17, 2024 06:21
@megglos megglos mentioned this pull request Apr 17, 2024
Closed
@megglos
Copy link
Contributor

megglos commented Apr 17, 2024 •
edited

@berkaycanbc I consider the scope of this change to be fine to get backported till 8.4 as this would help the web modeler team #8806 (comment)

I added the labels

@megglos megglos added backport stable/8.4 Backport a pull request to 8.4.x backport stable/8.5 Backport a pull request to stable/8.5 labels Apr 17, 2024
@megglos megglos force-pushed the bcan-8806-align-deployment-rejection-message-for-DMN-resources branch from 1ef7611 to 97cc009 Compare April 17, 2024 07:09
@berkaycanbc
Copy link
Contributor Author

@megglos the Tasklist CI test summary looks stuck in progress. Is it a known issue or is there a way to skip it?

@megglos
Copy link
Contributor

megglos commented Apr 17, 2024

@berkaycanbc right now we are lbocked by an operate issue, see https://camunda.slack.com/archives/C06HTSPD5AP/p1713341499813309

fix is incoming #17539

@megglos
Copy link
Contributor

megglos commented Apr 17, 2024

@berkaycanbc can you please rebase once #17539 is merged ?

@berkaycanbc
Copy link
Contributor Author

@berkaycanbc right now we are lbocked by an operate issue, see https://camunda.slack.com/archives/C06HTSPD5AP/p1713341499813309

fix is incoming #17539

@megglos okay, thanks.

@berkaycanbc can you please rebase once #17539 is merged ?

Yes!

@berkaycanbc
feat: Align deployment rejection message for DMN resources
b4a776a 
Included the resource name in the rejection message of DMN validation error.
Also, updated the related test to verify the expected behaviour.
@berkaycanbc berkaycanbc force-pushed the bcan-8806-align-deployment-rejection-message-for-DMN-resources branch from 97cc009 to b4a776a Compare April 18, 2024 14:20
@megglos megglos added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit 1c145ff Apr 18, 2024
39 checks passed
@megglos megglos deleted the bcan-8806-align-deployment-rejection-message-for-DMN-resources branch April 18, 2024 15:04
@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for stable/8.4 with exitcode 1

@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.4:

@backport-action backport-action mentioned this pull request Apr 18, 2024
Merged
@backport-action
Copy link
Collaborator

Git push to origin failed for stable/8.5 with exitcode 1

@github-actions github-actions bot mentioned this pull request Apr 18, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for stable/8.5:

github-merge-queue bot pushed a commit that referenced this pull request Apr 18, 2024
@camundait
[Backport stable/8.4] Align deployment rejection message for DMN reso…
3648ad2 
…urces (#17582)

# Description
Backport of #17475 to `stable/8.4`.

relates to #8806
original author: @berkaycanbc
github-merge-queue bot pushed a commit that referenced this pull request Apr 22, 2024
@berkaycanbc
Align deployment rejection message for DMN resources [Backport stable…
1b617d3 
…/8.5] (#17583)

# Description
Backport of #17475 to `stable/8.5`.
@Zelldon Zelldon added the version:8.4.7 Marks an issue as being completely or in parts released in 8.4.7 label May 7, 2024
@Zelldon Zelldon added the version:8.5.1 Marks an issue as being completely or in parts released in 8.5.1 label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megglos megglos megglos approved these changes

Assignees
No one assigned
Labels
backport stable/8.4 Backport a pull request to 8.4.x backport stable/8.5 Backport a pull request to stable/8.5 component/zeebe Related to the Zeebe component/team version:8.4.7 Marks an issue as being completely or in parts released in 8.4.7 version:8.5.1 Marks an issue as being completely or in parts released in 8.5.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align deployment rejection message for DMN resources
4 participants
@berkaycanbc @megglos @backport-action @Zelldon