fix: Make SnapshotStore IO bounded. #17718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be IO-bounded as before since most of the IO work is for taking snapshots.
rodrigo-lourenco-lopes
changed the title
rodrigo-lourenco-lopes
added
backport stable/8.2
rodrigo-lourenco-lopes
deleted the
17717-make-snapshot-store-io-bounded-instead-of-cpu
branch
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.2
git worktree add -d .worktree/backport-17718-to-stable/8.2 origin/stable/8.2
cd .worktree/backport-17718-to-stable/8.2
git switch --create backport-17718-to-stable/8.2
git cherry-pick -x 589a8abf8e92b3f1badde01cfabe36511f4c2cee |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
# Description Backport of #17718 to `stable/8.3`. relates to #17717 original author: @rodrigo-lourenco-lopes
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
# Description Backport of #17718 to `stable/8.4`. relates to #17717 original author: @rodrigo-lourenco-lopes
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
# Description Backport of #17718 to `stable/8.5`. relates to #17717 original author: @rodrigo-lourenco-lopes
Zelldon
added
version:8.4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should be IO-bounded as before since most of the IO work is for taking snapshots.
Related issues
closes #17717