Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: go client omit optional scope param if not set #18154

Merged
merged 1 commit into from
May 2, 2024
Merged

fix: go client omit optional scope param if not set #18154

merged 1 commit into from
May 2, 2024

Conversation

megglos
Copy link
Contributor

@megglos megglos commented May 2, 2024 •
edited

Description

The optional scope parameter was always sent with an empty string value on token request, if not explicitly set. This caused the token request to fail as either none or a valid scope needs to be provided.

Related issues

closes #16015

@megglos
fix: go client omit optional scope param
a9b899f 
The optional scope parameter was always sent with an empty string value on token request, if not explicitly set.
This caused the token request to fail.
@github-actions github-actions bot added the component/zeebe Related to the Zeebe component/team label May 2, 2024
@megglos
Copy link
Contributor Author

megglos commented May 2, 2024 •
edited

Validated manually with a local build of zbctl as well:

./zbctl.darwin --address=localhost:26500 --clientId=zeebe --clientSecret=zecret --audience=zeebe-api --authzUrl=http://localhost:18080/auth/realms/camunda-platform/protocol/openid-connect/token --insecure status
2024/05/02 07:21:05 Warning: The configured security level does not guarantee that the credentials will be confidential. If this unintentional, please enable transport security.
Cluster size: 1
Partitions count: 1
Replication factor: 1
Gateway version: 8.4.6
Brokers:
  Broker 0 - 172.26.0.6:26501
    Version: 8.4.6
    Partition 1 : Leader, Healthy

@megglos megglos added backport stable/8.4 Backport a pull request to 8.4.x backport stable/8.5 Backport a pull request to stable/8.5 labels May 2, 2024
@megglos megglos mentioned this pull request May 2, 2024
Merged
@megglos megglos changed the title fix: go client omit optional scope param fix: go client omit optional scope param if not set May 2, 2024
@megglos megglos requested a review from a team May 2, 2024 05:54
@megglos megglos added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit 7ceb10e May 2, 2024
42 checks passed
@megglos megglos deleted the meg-16015-fix-empty-scope-sent branch May 2, 2024 06:39
@backport-action backport-action mentioned this pull request May 2, 2024
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.4:

@backport-action backport-action mentioned this pull request May 2, 2024
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.5:

github-merge-queue bot pushed a commit that referenced this pull request May 2, 2024
@camundait
[Backport stable/8.4] fix: go client omit optional scope param if not…
6fdef27 
… set (#18155)

# Description
Backport of #18154 to `stable/8.4`.

relates to #16015
original author: @megglos
github-merge-queue bot pushed a commit that referenced this pull request May 7, 2024
@Zelldon
[Backport stable/8.5] fix: go client omit optional scope param if not…
50b4984 
… set (#18156)

# Description
Backport of #18154 to `stable/8.5`.

relates to #16015
original author: @megglos
github-merge-queue bot pushed a commit that referenced this pull request May 7, 2024
@megglos
[Backport stable/8.5] fix: go client omit optional scope param if not…
6006965 
… set (#18156)

# Description
Backport of #18154 to `stable/8.5`.

relates to #16015
original author: @megglos
@Zelldon Zelldon added version:8.4.7 Marks an issue as being completely or in parts released in 8.4.7 version:8.5.1 Marks an issue as being completely or in parts released in 8.5.1 labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicpuppa nicpuppa nicpuppa approved these changes

Assignees
No one assigned
Labels
backport stable/8.4 Backport a pull request to 8.4.x backport stable/8.5 Backport a pull request to stable/8.5 component/zeebe Related to the Zeebe component/team version:8.4.7 Marks an issue as being completely or in parts released in 8.4.7 version:8.5.1 Marks an issue as being completely or in parts released in 8.5.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zbctl 8.4.0 can't send requests with authorization information
4 participants
@megglos @backport-action @nicpuppa @Zelldon