Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symlink .idea folder for zeebe subfolder #18165

Merged
merged 1 commit into from
May 2, 2024
Merged

Symlink .idea folder for zeebe subfolder #18165

merged 1 commit into from
May 2, 2024

Conversation

korthout
Copy link
Member

@korthout korthout commented May 2, 2024 •
edited

Description

It's annoying to open the mono repo in IntelliJ when working only on Zeebe. I prefer to work in the zeebe subfolder. However, that means that all the shared idea settings are not available.

By symlinking the .idea folder users that open the zeebe subfolder in IntelliJ will have all the same settings as the mono repo, without having to duplicate the settings.

This change does not affect anyone that works from the mono repo in IntelliJ.

This PR adds a soft symlink created using:

cd zeebe
ln -s ../.idea .idea

Related issues

None

@korthout
build: symlink idea folder for zeebe
2eae541 
It's annoying to open the mono repo in IntelliJ when working only on
Zeebe. I prefer to work in the `zeebe` subfolder. However, that means
that all the shared idea settings are not available.

By symlinking the .idea folder users that open the zeebe subfolder in
IntelliJ will have all the same settings as the mono repo, without
having to duplicate the settings.

This change does not affect anyone that works from the mono repo in
IntelliJ.
@korthout korthout requested review from a team May 2, 2024 08:27
@github-actions github-actions bot added the component/zeebe Related to the Zeebe component/team label May 2, 2024
@korthout korthout added the backport stable/8.5 Backport a pull request to stable/8.5 label May 2, 2024
Zelldon
Zelldon approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might not work with windows, but not sure whether Zeebe engineers use windows I think linux/mac is more common in this area. :)

So lets fix it if it turns to be an issue. LGTM 👍🏼 :shipit:

@nicpuppa
Copy link
Contributor

nicpuppa commented May 2, 2024

It might not work with windows, but not sure whether Zeebe engineers use windows I think linux/mac is more common in this area. :)

@tmetzke 🙃

@tmetzke
Copy link
Member

tmetzke commented May 2, 2024

I am working with the mono repo, so 🤷
I can give it a try with a new Zeebe-only workspace.

@mustafadagher
Copy link
Contributor

Nice idea @korthout !
Did you try a scenario where you change the editorconfig or some other idea configs while you're on the zeebe subfolder. what would be the outcome?

@korthout
Copy link
Member Author

korthout commented May 2, 2024

Did you try a scenario where you change the editorconfig or some other idea configs while you're on the zeebe subfolder. what would be the outcome?

@mustafadagher I haven't tested this, but I expect that it works just like the rest. In the Zeebe subfolder project, you'll have the exact same settings as in the mono repo.

@korthout
Copy link
Member Author

korthout commented May 2, 2024

Ok, let's get this merged. If anyone objects, we can revert it. Please speak up if this PR causes you any issues.

@korthout korthout added this pull request to the merge queue May 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2024
@korthout
Copy link
Member Author

korthout commented May 2, 2024 •
edited

Seems that our CI is unstable. Let's retry that once. Otherwise, I'll wait until it stabilizes.

@korthout korthout added this pull request to the merge queue May 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2024
@Zelldon Zelldon added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit 937bbc7 May 2, 2024
39 checks passed
@Zelldon Zelldon deleted the korthout-symlink-idea-folder-zeebe branch May 2, 2024 21:52
@backport-action backport-action mentioned this pull request May 2, 2024
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.5:

github-merge-queue bot pushed a commit that referenced this pull request May 3, 2024
@korthout
[Backport stable/8.5] Symlink .idea folder for zeebe subfolder (#…
974ba27 
…18195)

# Description
Backport of #18165 to `stable/8.5`.

relates to
original author: @korthout
@Zelldon Zelldon added the version:8.5.1 Marks an issue as being completely or in parts released in 8.5.1 label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zelldon Zelldon Zelldon approved these changes

Assignees
No one assigned
Labels
backport stable/8.5 Backport a pull request to stable/8.5 component/zeebe Related to the Zeebe component/team version:8.5.1 Marks an issue as being completely or in parts released in 8.5.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@korthout @nicpuppa @tmetzke @mustafadagher @backport-action @Zelldon