Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing token validity verification that was causing authentication error #18166

Merged
merged 1 commit into from
May 3, 2024

Conversation

ana-vinogradova-camunda
Copy link
Contributor

Fix for this issue

  • Before the fix: token was still considered valid for 30 seconds after its expiration. That was resulting in UNAUTHENTICATED error.
  • The fix: method to check for token validity returns false if token already expired by now.

Related issues

closes #17799

@ana-vinogradova-camunda ana-vinogradova-camunda added scope/spring-boot-starter-camunda Spring Boot Starter Camunda backport stable/8.5 Backport a pull request to stable/8.5 labels May 2, 2024
@github-actions github-actions bot added the component/zeebe Related to the Zeebe component/team label May 2, 2024
Copy link
Contributor

@nicpuppa nicpuppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Please rebase the branch 🍪

Before this fix token was still considered valid for 30 seconds after
its expiration.
The fix: check for token validity returns false if token already expired
 by now.
@ana-vinogradova-camunda ana-vinogradova-camunda added this pull request to the merge queue May 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2024
@ana-vinogradova-camunda ana-vinogradova-camunda added this pull request to the merge queue May 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2024
@nicpuppa nicpuppa added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 44bf6d6 May 3, 2024
39 checks passed
@nicpuppa nicpuppa deleted the 17799-fix-unauthenticated-error branch May 3, 2024 05:18
@backport-action
Copy link
Collaborator

github-merge-queue bot pushed a commit that referenced this pull request May 7, 2024
…sing authentication error (#18202)

# Description
Backport of #18166 to `stable/8.5`.

relates to #17799
original author: @ana-vinogradova-camunda
@Zelldon Zelldon added the version:8.5.1 Marks an issue as being completely or in parts released in 8.5.1 label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable/8.5 Backport a pull request to stable/8.5 component/zeebe Related to the Zeebe component/team scope/spring-boot-starter-camunda Spring Boot Starter Camunda version:8.5.1 Marks an issue as being completely or in parts released in 8.5.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spring Zeebe SDK] Token not refreshed
4 participants