test: ensure no leader before restarting outdated follower #18203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was flaky because we were looking for a leader among m1 and m2. But it should be m1 and m2Restarted. In the flaky case, m2Restarted was the leader. This was not the intention of the test, because node 2 must be outdated at this point and cannot become the leader. But in this case, the shutdowns and restarts were so fast that leader m1 didn't get a chance to step down. So when m2 was restarted, it immediatly got the latest log entry and was able to become the leader immediately after the force configure is completed. To prevent this case, we now wait until there is no leader, before restarting node 2.
|
PR is blocked at step "SDK test summary" which doesn't exist in this branch. Rebasing on main. |
deepthidevaki
force-pushed
the
dd-17670-flaky-reconfigure
branch
from
7da955e
to
86b6d8c
Compare
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 6, 2024
…ed follower (#18259) # Description Backport of #18203 to `stable/8.5`. relates to #17670 original author: @deepthidevaki
Zelldon
added
the
version:8.5.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test was flaky because we were looking for a leader among m1 and m2. But it should be m1 and m2Restarted. In the flaky case, m2Restarted was the leader. This was not the intention of the test, because node 2 must be outdated at this point and cannot become the leader. But in this case, the shutdowns and restarts were so fast that leader m1 didn't get a chance to step down. So when m2 was restarted, it immediately got the latest log entry and was able to become the leader immediately after the force configure is completed. To prevent this case, we now wait until there is no leader, before restarting node 2.
Related issues
closes #17670