Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add leading slash to opensearch endpoints #18253

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: add leading slash to opensearch endpoints #18253

merged 1 commit into from
May 6, 2024

Conversation

megglos
Copy link
Contributor

@megglos megglos commented May 6, 2024

Description

While the bare opensearch service allows a missing leading slash, the AWS service or it's ingress doesn't, returning a 400.

As I don't see an easy way to cover this in our ITs we may consider following up with a nightly IT on prepared AWS Opensearch instance see #18252 .

Related issues

closes #18251

@github-actions github-actions bot added the component/zeebe Related to the Zeebe component/team label May 6, 2024
@megglos
fix: add leading slash to opensearch endpoints
0752796 
While the bare opensearch service allows a missing leading slash,
the AWS service, or it's ingress doesn't, returning a 400.
@megglos megglos force-pushed the meg-18251-fix-opensearch-aws-400 branch from d28b46f to 0752796 Compare May 6, 2024 04:56
@megglos megglos added backport stable/8.4 Backport a pull request to 8.4.x backport stable/8.5 Backport a pull request to stable/8.5 labels May 6, 2024
mustafadagher
mustafadagher approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@mustafadagher mustafadagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

I don't have an AWS account to test it myself, but I assume you did :)

@megglos megglos added this pull request to the merge queue May 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2024
@megglos megglos added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit c9b4a7c May 6, 2024
48 checks passed
@megglos megglos deleted the meg-18251-fix-opensearch-aws-400 branch May 6, 2024 13:50
@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.4:

@backport-action backport-action mentioned this pull request May 6, 2024
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.5:

This was referenced May 6, 2024
Merged
Merged
@backport-action
Copy link
Collaborator

Successfully created backport PR for release-8.6.0-alpha1:

github-merge-queue bot pushed a commit that referenced this pull request May 6, 2024
@camundait
[Backport stable/8.4] fix: add leading slash to opensearch endpoints (#…
ed1313c 
…18274)

# Description
Backport of #18253 to `stable/8.4`.

relates to #18252 #18251
original author: @megglos
github-merge-queue bot pushed a commit that referenced this pull request May 6, 2024
@camundait
[Backport stable/8.5] fix: add leading slash to opensearch endpoints (#…
fa65441 
…18275)

# Description
Backport of #18253 to `stable/8.5`.

relates to #18252 #18251
original author: @megglos
megglos added a commit that referenced this pull request May 6, 2024
@megglos
[Backport release-8.6.0-alpha1] fix: add leading slash to opensearch …
e1e64a5 
…endpoints (#18276)

# Description
Backport of #18253 to `release-8.6.0-alpha1`.

relates to #18252 #18251
original author: @megglos
@Zelldon Zelldon added version:8.4.7 Marks an issue as being completely or in parts released in 8.4.7 version:8.5.1 Marks an issue as being completely or in parts released in 8.5.1 version:8.6.0-alpha1 labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustafadagher mustafadagher mustafadagher approved these changes

Assignees
No one assigned
Labels
backport stable/8.4 Backport a pull request to 8.4.x backport stable/8.5 Backport a pull request to stable/8.5 component/zeebe Related to the Zeebe component/team version:8.4.7 Marks an issue as being completely or in parts released in 8.4.7 version:8.5.1 Marks an issue as being completely or in parts released in 8.5.1 version:8.6.0-alpha1 Label that represents issues released on verions 8.6.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opensearch exporter fails with 400 on AWS Opensearch service
4 participants
@megglos @backport-action @mustafadagher @Zelldon