Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3803 job retries feel expression #4126

Merged
merged 2 commits into from
Mar 26, 2020
Merged

3803 job retries feel expression #4126

merged 2 commits into from
Mar 26, 2020
+323 −61

Conversation

pihme
Copy link
Contributor

@pihme pihme commented Mar 25, 2020

Description

Added FEEL expressions for job retries

Related issues

closes #3803

Pull Request Checklist

  • [ X ] All commit messages match our commit message guidelines
  • [ X ] The submitting code follows our code style
  • [ X ] If submitting code, please run mvn clean install -DskipTests locally before committing

@pihme pihme requested a review from saig0 March 25, 2020 11:45
saig0
saig0 approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

Just one comment on the unit test. Since I don't have a strong optional on this point, feel free to ignore it.

expression-language/src/test/java/io/zeebe/el/impl/StaticExpressionTest.java Outdated Show resolved Hide resolved
@pihme pihme force-pushed the 3803-job-retries-feel-expression branch from ba43dd3 to 333709f Compare March 26, 2020 15:36
@pihme
Copy link
Contributor Author

pihme commented Mar 26, 2020

bors r+

zeebe-bors bot added a commit that referenced this pull request Mar 26, 2020
@zeebe-bors @pihme
Merge #4126
79ca231 
4126: 3803 job retries feel expression r=pihme a=pihme

## Description

Added FEEL expressions for job retries

## Related issues

closes #3803

#

Co-authored-by: pihme <pihme@users.noreply.github.com>
@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Mar 26, 2020

Build failed

@pihme pihme force-pushed the 3803-job-retries-feel-expression branch from 333709f to f15bb1b Compare March 26, 2020 16:56
@pihme pihme force-pushed the 3803-job-retries-feel-expression branch from f15bb1b to a436b99 Compare March 26, 2020 17:22
@pihme
Copy link
Contributor Author

pihme commented Mar 26, 2020

bors retry

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Mar 26, 2020

Build succeeded

@zeebe-bors zeebe-bors bot merged commit 0b7554d into develop Mar 26, 2020
@zeebe-bors zeebe-bors bot deleted the 3803-job-retries-feel-expression branch March 26, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saig0 saig0 saig0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define the job retries statically or as expression
2 participants
@pihme @saig0