fix(broker): use exporter positions to calculate compactable index in snapshots #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… snapshots - use concrete entry supplier in AtomixSnapshotStorageTest instead of mocks - use ZeebeIndexMapping and RaftLogReader directly to supply the correct Atomix entry for snapshot metadata - do not create a snapshot if a snapshot with that index already exists - add context map to stackdriver logs - update exported position in RecordingExporter - ensure log density is 1 in QA tests that require snapshotting with low synthetic loads - include partition in ZeebeRaftStateMachine log context
deepthidevaki
approved these changes
Apr 24, 2020
|
bors r+ |
zeebe-bors bot
added a commit
that referenced
this pull request
Apr 24, 2020
4374: fix(broker): use exporter positions to calculate compactable index in snapshots r=npepinpe a=npepinpe ## Description - use concrete entry supplier in AtomixSnapshotStorageTest instead of mocks - use ZeebeIndexMapping and RaftLogReader directly to supply the correct Atomix entry for snapshot metadata - do not create a snapshot if a snapshot with that index already exists - add context map to stackdriver logs - update exported position in RecordingExporter - ensure log density is 1 in QA tests that require snapshotting with low synthetic loads - include partition in ZeebeRaftStateMachine log context ## Related issues closes #4350 # Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
Build failed |
|
bors retry |
3 tasks
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
closes #4350
Pull Request Checklist
mvn clean install -DskipTestslocally before committing