Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(broker): prevent auto config of elasticsearch client #4495

Merged
merged 1 commit into from
May 12, 2020

Conversation

pihme
Copy link
Contributor

@pihme pihme commented May 11, 2020

Description

Prevent ElasticSearch auto configuration.

Related issues

closes #4403

Pull Request Checklist

  • [ X ] All commit messages match our commit message guidelines
  • [ X ] The submitting code follows our code style
  • [ X ] If submitting code, please run mvn clean install -DskipTests locally before committing

@pihme pihme requested a review from npepinpe May 11, 2020 15:19
Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks! Can't see non-relevant threads any more, so I assume the client isn't created.

Could this be an issue with future dependencies we add? How could we better detect it when we add dependencies that might get auto configured?

@pihme
Copy link
Contributor Author

pihme commented May 12, 2020

bors r+

@pihme
Copy link
Contributor Author

pihme commented May 12, 2020

Not sure how we can detect similar situations for the next dependency.

We could scan the new dependencies for @Configuration annotations. Other than that, I don't know.

For now, I would wait and see.

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented May 12, 2020

Build succeeded

@zeebe-bors zeebe-bors bot merged commit 43e195a into develop May 12, 2020
@zeebe-bors zeebe-bors bot deleted the 4403-prevent-elasticsearch-client-autoconfig branch May 12, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StandaloneBroker auto configures an Elasticsearch client
2 participants