fix(gateway, broker, clients/java): allow to use IPv6 addresses in a cluster #6792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
pushed a commit
that referenced
this pull request
Apr 18, 2021
6792: fix(gateway, broker, clients/java): allow to use IPv6 addresses in a cluster r=npepinpe a=aivinog1 ## Description This is the backported #6484 to 0.26 ## Related issues <!-- Which issues are closed by this PR or are related --> closes #5951 <!-- Cut-off marker _All lines under and including the cut-off marker will be removed from the merge commit message_ ## Definition of Ready Please check the items that apply, before requesting a review. You can find more details about these items in our wiki page about [Pull Requests and Code Reviews](https://github.com/camunda-cloud/zeebe/wiki/Pull-Requests-and-Code-Reviews). * [ ] I've reviewed my own code * [ ] I've written a clear changelist description * [ ] I've narrowly scoped my changes * [ ] I've separated structural from behavioural changes --> ## Definition of Done <!-- Please check the items that apply, before merging or (if possible) before requesting a review. --> _Not all items need to be done depending on the issue and the pull request._ Code changes: * [X] The changes are backwards compatibility with previous versions * [X] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. `backport stable/0.25`) to the PR, in case that fails you need to create backports manually. Testing: * [X] There are unit/integration tests that verify all acceptance criterias of the issue * [X] New tests are written to ensure backwards compatibility with further versions * [ ] The behavior is tested manually * [X] The change has been verified by a QA run * [ ] The impact of the changes is verified by a benchmark Documentation: * [X] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.) * [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape) Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
|
Build failed: |
|
There's an issue with the BPMN TCK due to it using an "old" Testcontainers version. We can disable it for now, as anyway we'll need to work on it post 1.0. |
|
bors retry |
ghost
pushed a commit
that referenced
this pull request
Apr 19, 2021
6792: fix(gateway, broker, clients/java): allow to use IPv6 addresses in a cluster r=npepinpe a=aivinog1 ## Description This is the backported #6484 to 0.26 ## Related issues <!-- Which issues are closed by this PR or are related --> closes #5951 <!-- Cut-off marker _All lines under and including the cut-off marker will be removed from the merge commit message_ ## Definition of Ready Please check the items that apply, before requesting a review. You can find more details about these items in our wiki page about [Pull Requests and Code Reviews](https://github.com/camunda-cloud/zeebe/wiki/Pull-Requests-and-Code-Reviews). * [ ] I've reviewed my own code * [ ] I've written a clear changelist description * [ ] I've narrowly scoped my changes * [ ] I've separated structural from behavioural changes --> ## Definition of Done <!-- Please check the items that apply, before merging or (if possible) before requesting a review. --> _Not all items need to be done depending on the issue and the pull request._ Code changes: * [X] The changes are backwards compatibility with previous versions * [X] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. `backport stable/0.25`) to the PR, in case that fails you need to create backports manually. Testing: * [X] There are unit/integration tests that verify all acceptance criterias of the issue * [X] New tests are written to ensure backwards compatibility with further versions * [ ] The behavior is tested manually * [X] The change has been verified by a QA run * [ ] The impact of the changes is verified by a benchmark Documentation: * [X] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.) * [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape) Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
|
Build failed: |
|
bors retry Weird, as this test was never flaky before 🤔 |
|
Build succeeded: |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the backported #6484 to 0.26
Related issues
closes #5951
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/0.25) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: