fix(engine): update the key generator on replay #8156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On replay, update the key generator with the replayed record's key. This fixes an issue where the follower would restart with a snapshot where nothing needed to be replayed, and would thus not update its generated key, leading to processing starting with the wrong key and duplicate keys, causing state inconsistencies.
Test should verify key column, to make sure on replay and processing key column family is filled.
|
Please recreate against stable/1.2, as this is the PR that should be merged first. We can later port it to develop. |
Regression test which verifies that no duplicated keys are generated on the log, after fail over
|
Working on another PR to backport the fix and tests. 🏃 |
9 tasks
saig0
approved these changes
Nov 5, 2021
ghost
pushed a commit
that referenced
this pull request
Nov 5, 2021
8158: [Backport 1.2] Update the key generator on replay r=npepinpe a=Zelldon ## Description Backports the fix from #8156 and adjusts the IT test to get it work with 1.2. Snapshot need to be taken so the new leader will not replay the complete log and start with the latest state he had. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> related to #8129 Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com> Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
bors merge |
|
Build succeeded: |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On replay, update the key generator with the replayed record's key. This fixes an issue where the follower would restart with a snapshot where nothing needed to be replayed, and would thus not update its generated key, leading to processing starting with the wrong key and duplicate keys, causing state inconsistencies.
Related issues
closes #8129
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/0.25) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: